From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] src/process.c: remove unnecessary setters Date: Mon, 29 May 2017 18:40:21 -0700 Message-ID: <87tw43t94q.fsf@SoraLaptop> References: <87shjnmeag.fsf@SoraLaptop> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496108476 24550 195.159.176.226 (30 May 2017 01:41:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 01:41:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 30 03:41:11 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFW9k-000642-0p for ged-emacs-devel@m.gmane.org; Tue, 30 May 2017 03:41:08 +0200 Original-Received: from localhost ([::1]:51108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFW9m-0000W2-8n for ged-emacs-devel@m.gmane.org; Mon, 29 May 2017 21:41:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFW9A-0000Vj-I3 for emacs-devel@gnu.org; Mon, 29 May 2017 21:40:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFW95-0008Qo-TL for emacs-devel@gnu.org; Mon, 29 May 2017 21:40:32 -0400 Original-Received: from vps28183.inmotionhosting.com ([23.235.221.66]:44368) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFW95-0008Oi-Lb for emacs-devel@gnu.org; Mon, 29 May 2017 21:40:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cochranmail.com; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jm/Yb6gicbPYergYefsH3bAfszZaiC6ZFTLXNZBAMnU=; b=OQ+2byLIcEigWXggToyQ7Zdow m3AMsHBRQ/ic8msXyQNSoEeWb8S93mktWI7uRJqfj4hZS6geqy4QMaBfVg3oID9ExtXj3CLI5AGR5 hma1RkZYFMgIWlTWpPDFByvFLZNJOLUH5F0WQXAwtHJKGarPbIoOU1KWM7W5PGQkfOAS4WlmETnct g9DFesW8IJGX095HlsCsNnbPeOrcTHqE2C8T8XPy0zwGT3pj2Imtn8iYcn8ZgPKWDOP6UMy26X1Cg hbfMNK110ozwaTl9rMOGCYFX2xcAJ7wji5XAjkv2HTuT7eqfKVsEOGrHts7x5kBpkNh+s31ZO4BLF 5I7B7Xttw==; Original-Received: from 131-191-86-130.as.clicknet.org ([131.191.86.130]:50704 helo=SoraLaptop) by vps28183.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dFW93-0004w7-Uu; Mon, 29 May 2017 18:40:26 -0700 In-Reply-To: (Paul Eggert's message of "Mon, 29 May 2017 16:47:30 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps28183.inmotionhosting.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - cochranmail.com X-Get-Message-Sender-Via: vps28183.inmotionhosting.com: authenticated_id: robert@cochranmail.com X-Authenticated-Sender: vps28183.inmotionhosting.com: robert@cochranmail.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 23.235.221.66 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215333 Archived-At: Paul Eggert writes: > As I recall those setters and getters were put in for a reason. Have you > consulted the development history and emacs-devel logs to see why, and/or > contacted whoever added that code? Not anymore, based on what I see. With some git-blame history digging, here's what I found: Dmitry Antipov added the ancestor PVAR macro in 3193acd2 "Use INTERNAL_FIELD for processes." on 08/01/2012, and made the struct fields use the INTERNAL_FIELD macro in the same commit. This was split into two macros PGET and PSET in 21238f11 "Separate read and write access to Lisp_Object slots of Lisp_Process." on 08/06/2012. On 08/07/2012, he entirely drops PGET and removes the use of INTERNAL_FIELD in 4d2b044c "Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process". Then it was you that removed PSET in favor of individual setters in 6a09a33b "* process.h (PSET): Remove.", where the code has sat mostly untouched since 08/18/2012 aside from being de-inlined by you in b0ab8123d "Prefer plain 'static' to 'static inline'." on 09/30/2012. Especially given that in 2015, INTERNAL_FIELD was removed (according to ChangeLog.2 at any rate), it looks like the reason for the functions removed to be abstracted away has long since become irrelevant. I could be wrong though. I'm wrong a lot. -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871