From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces Date: Mon, 02 Oct 2017 01:36:08 +0100 Message-ID: <87tvzigzd3.fsf@lolita> References: <20171001123811.5647.26035@vcs0.savannah.gnu.org> <20171001123812.A22F12068C@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1506904586 26463 195.159.176.226 (2 Oct 2017 00:36:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Oct 2017 00:36:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 02 02:36:21 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyoia-0006I1-AR for ged-emacs-devel@m.gmane.org; Mon, 02 Oct 2017 02:36:20 +0200 Original-Received: from localhost ([::1]:50186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyoih-00028K-Gt for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 20:36:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyoiZ-000284-7W for emacs-devel@gnu.org; Sun, 01 Oct 2017 20:36:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyoiV-0005Ay-Vt for emacs-devel@gnu.org; Sun, 01 Oct 2017 20:36:19 -0400 Original-Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:44095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyoiV-00059L-Fn for emacs-devel@gnu.org; Sun, 01 Oct 2017 20:36:15 -0400 Original-Received: by mail-wm0-x231.google.com with SMTP id 196so858257wma.1 for ; Sun, 01 Oct 2017 17:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=typtVHOUYtFnZPLFrUJ8db99rwvh7mZ38KC9Vy0ypTw=; b=WHswr77yETnfiZDTUrPrukO5MlkEdlJSajjVqcjZWR89JXONq7/H5zaGltOU0sCeXL MpQrkiAK8CuQRcjzuyaEAmAzAeyRian1Yl0WMHXlhDLh6bm3riXvPMM64THO4Dvd64ry ezCq1w6rpeJEstw12uR0bvQ40psj/kcaB7dRGLFvJakQipC3G0Q2EpRM/AbaNFowBPBl SCesXtr4tmCLyEhrpYofaCTDJqMTUZ0fhFsfl8yjf52IQEs3WBWq31URnfVL0p2Ic1UY /evPT2Quj7wcwzhDWMXM3N1KsbbXZEzO7kvi/X+8byoPPaf26itxRBCsRtRtOnXUJOYi +eWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=typtVHOUYtFnZPLFrUJ8db99rwvh7mZ38KC9Vy0ypTw=; b=X8P29RQ8qR6BBy8MZXAI96bcHhithagumwORxzO9Y9eTNLs3zJzvnSwyWQ66H5j1lz qHiRr5XJBrIElHE2+S1ersQZX/Uj36YgWw2HWv9UF+ywmJpBclpWGlmeOeaqqJ3FFHLt uZjNI4Nn5J8jE7G3WOk3f9f3Opg1heEk63hAGveQZolouJyPsedzgSETiZpXabtzPoKu VOxC5U3ulDWRfY2cWezt4D8tp4CJ+QW4jXs3NGAzml0/1HCjgAEKWJ5O7MIHIQDK1tI0 Cg85Vo0sI2cLw+pP5VjQeNeqBTK/eAXhaOCZSxmCiDylR+SOfRGHH/4ZAtGvYVoVgCwx 2l+g== X-Gm-Message-State: AMCzsaWTmh2VKVbdvzDZbEumI+b0qdJ2pRRFNPl48aqHXUzhfjcz2+gS qfLdWl7nYSEh0NwsHkVER+U1wH7e X-Google-Smtp-Source: AOwi7QA/b0UhbsocM0RH62SO/dULzkdNRYKMYHFFysBhOPKfFVAi1oUCBcf/hhAnfiU9J/fGr6IMKg== X-Received: by 10.28.29.215 with SMTP id d206mr3968935wmd.130.1506904573753; Sun, 01 Oct 2017 17:36:13 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id 31sm3188343wru.33.2017.10.01.17.36.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Oct 2017 17:36:13 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 01 Oct 2017 17:40:57 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218995 Archived-At: Stefan Monnier writes: >> * lisp/emacs-lisp/bytecomp.el >> (byte-compile-log-warning-function): New variable. >> (byte-compile-log-warning): Use it. >> (byte-compile--log-warning-for-byte-compile): New function. > > Looking at it, I think it'd be more useful to add > a `display-warning-function` which applies to all calls to > display-warning. OTOH, we're not exactly "displaying" a warning, we're collecting one. >> * lisp/emacs-lisp/checkdoc.el >> (checkdoc-create-error-function): New variable. >> (checkdoc-create-error): Use it. >> (checkdoc--create-error-for-checkdoc): New function.xo > > As for this one, I see that checkdoc-create-error can be either > "declarative" (it just builds an object, with no side-effect) or not > depending on checkdoc-generate-compile-warnings-flag. > This sounds like checkdoc already has some of the design we need (it > can construct error objects and then return them), but maybe some more > serious refactoring would be needed to make it really work for flymake. > No time to look deeper into it now, No problem. As I think I said in the commit message these two "proper" interfaces are just pure boilerplate. Feel free to change them. Jo=C3=A3o