From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Tab bar tabs landed on master Date: Wed, 02 Oct 2019 19:30:15 +0300 Organization: LINKOV.NET Message-ID: <87tv8rp0ww.fsf@mail.linkov.net> References: <8736gci5jn.fsf@mail.linkov.net> <87zhikp0ba.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154258"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: Juanma Barranquero , Emacs developers To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 18:32:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFhYN-000dyP-05 for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 18:32:39 +0200 Original-Received: from localhost ([::1]:57592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhYL-0006tF-Kp for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 12:32:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60489) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhXf-0006TN-CH for emacs-devel@gnu.org; Wed, 02 Oct 2019 12:31:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFhXe-0002BM-4z for emacs-devel@gnu.org; Wed, 02 Oct 2019 12:31:55 -0400 Original-Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:49212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFhXd-0002Ay-RC for emacs-devel@gnu.org; Wed, 02 Oct 2019 12:31:54 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5798E502E9E; Wed, 2 Oct 2019 16:31:52 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (100-96-169-131.trex.outbound.svc.cluster.local [100.96.169.131]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D1F3B502749; Wed, 2 Oct 2019 16:31:50 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.2); Wed, 02 Oct 2019 16:31:52 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Eight-Spill: 31f80d743e92a3b4_1570033911252_4274519148 X-MC-Loop-Signature: 1570033911252:2660008416 X-MC-Ingress-Time: 1570033911251 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 9818A85003; Wed, 2 Oct 2019 09:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=YJOB2+eXSD63mbQEcBX9bWx/Zgg=; b= Ys86ollZzmUH7ibUbRcSjhqGROjxUydwF2udAXhjNgsNRfgUGzM+1Oe0ibgc2BfX E7pW3XFSQMZGYDBgp8aFpgKbBOGQoyWBatVts9tVxC2X3nI0mdSAtG7HofeIIhNZ ON5iHnEyLMtAJZsXMi+GUyd1iV3mFyKxUwoe6Mdj+GA= Original-Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 8C21285018; Wed, 2 Oct 2019 09:31:42 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: (martin rudalics's message of "Wed, 2 Oct 2019 10:55:26 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeeigddutdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtnecuvehluhhsthgvrhfuihiivgepud X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.212.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240475 Archived-At: >> On GNU/Linux it's correct: > > Not with a Motif build. I tried to build Lucid and it successfully compiled. But this problem is not reproducible on Lucid. Then I tried to rebuild with Motif, but compilation failed with: ../lwlib/liblw.a(lwlib.o): In function `set_one_value': ../lwlib/lwlib.c:529: undefined reference to `lw_lucid_widget_p' ../lwlib/lwlib.c:530: undefined reference to `xlw_update_one_widget' ../lwlib/lwlib.c:537: undefined reference to `lw_xaw_widget_p' ../lwlib/lwlib.c:538: undefined reference to `xaw_update_one_widget' ../lwlib/liblw.a(lwlib.o): In function `instantiate_widget_instance': ../lwlib/lwlib.c:690: undefined reference to `xlw_creation_table' ../lwlib/lwlib.c:698: undefined reference to `xaw_creation_table' ../lwlib/lwlib.c:714: undefined reference to `xaw_create_dialog' ../lwlib/liblw.a(lwlib.o): In function `destroy_one_instance': ../lwlib/lwlib.c:812: undefined reference to `lw_lucid_widget_p' ../lwlib/lwlib.c:813: undefined reference to `xlw_destroy_instance' ../lwlib/lwlib.c:822: undefined reference to `lw_xaw_widget_p' ../lwlib/lwlib.c:823: undefined reference to `xaw_destroy_instance' ../lwlib/liblw.a(lwlib.o): In function `lw_pop_all_widgets': ../lwlib/lwlib.c:940: undefined reference to `lw_lucid_widget_p' ../lwlib/lwlib.c:943: undefined reference to `xlw_pop_instance' ../lwlib/lwlib.c:954: undefined reference to `lw_xaw_widget_p' ../lwlib/lwlib.c:958: undefined reference to `xaw_pop_instance' ../lwlib/liblw.a(lwlib.o): In function `lw_popup_menu': ../lwlib/lwlib.c:980: undefined reference to `lw_lucid_widget_p' ../lwlib/lwlib.c:981: undefined reference to `xlw_popup_menu' ../lwlib/lwlib.c:988: undefined reference to `lw_xaw_widget_p' ../lwlib/lwlib.c:989: undefined reference to `xaw_popup_menu' ../lwlib/liblw.a(lwlib.o): In function `get_one_value': ../lwlib/lwlib.c:1002: undefined reference to `lw_lucid_widget_p' ../lwlib/lwlib.c:1003: undefined reference to `xlw_update_one_value' ../lwlib/lwlib.c:1010: undefined reference to `lw_xaw_widget_p' ../lwlib/lwlib.c:1011: undefined reference to `xaw_update_one_value' ../lwlib/liblw.a(lwlib.o): In function `lw_refigure_widget': ../lwlib/lwlib.c:1179: undefined reference to `XawPanedSetRefigureMode' Then I used `make clean' in the lwlib directory, and compilation succeeded. And indeed, this problem is reproducible with a Motif build. >> OTOH, for the tool-bar the problem exists: >> >> (let ((initial (assq 'outer-size (frame-geometry)))) >> (tool-bar-mode 1) >> (tool-bar-mode 0) >> (list (assq 'outer-size (frame-geometry)) initial)) >> >> => ((outer-size 678 . 587) (outer-size 678 . 633)) >> >> in both Emacs 27 and GNU Emacs 25.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21) > > No problem here. The first call returns the height including the tool > bar, the second call the height without it. Please try running `emacs -Q -f tool-bar-mode' that disables tool-bar-mode before it's displayed first time.