From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-27 38f7538 1/2: New function erc-switch-to-buffer-other-window Date: Tue, 14 Apr 2020 11:59:10 -0400 Organization: GNU Message-ID: <87tv1m6ott.fsf@gnu.org> References: <83lfmyiqkb.fsf@gnu.org> <87zhbe6qzh.fsf@gnu.org> <831roqhxvt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="10717"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 18:00:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jONyj-0002Up-Ee for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 18:00:01 +0200 Original-Received: from localhost ([::1]:33036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jONyi-0005dF-Gk for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 12:00:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47219) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jONxw-0004il-Iv for emacs-devel@gnu.org; Tue, 14 Apr 2020 11:59:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jONxw-00076a-FC for emacs-devel@gnu.org; Tue, 14 Apr 2020 11:59:12 -0400 Original-Received: from [2607:fea8:3fe0:17d:f40c:88a4:d22:b12e] (port=45766 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jONxv-0004uh-Ps; Tue, 14 Apr 2020 11:59:11 -0400 Mail-Followup-To: Eli Zaretskii , emacs-devel@gnu.org In-Reply-To: <831roqhxvt.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246943 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Amin Bandali >> Cc: emacs-devel@gnu.org >> Date: Tue, 14 Apr 2020 11:12:34 -0400 >>=20 >> I think the changes are simple yet useful enough to be in emacs-27; >> though in hindsight, the master branch may have been a better place for >> them. That said, if you or others spot any issues with them, I'd be >> more than happy to try and address them, or even revert them if needed. > > The danger is that we release Emacs 27.1 with some problem caused by > these changes undetected. But if you think this danger is small, I > guess I'm okay with that. > > Thanks. > Makes sense. In this specific case, I really do think the danger is small, as I didn't make any changes to the implementation logic for either of the two original functions, and the two new functions only differ from the original ones in using `switch-to-buffer-other-window'. That said if there is anything unclear or suspicious-looking about my changes, please let me know and I will revert them and apply them to master instead. Thanks, amin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl6V3c4QHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8k8+EACeiEpZm9YlDVHWcUHxmIYQadm/F7s6/50J dGj/61XepwQFz5uE0Tz5k2iTVBchwLX871W1uMW1F5Ftdce/Eqa6oyDukO/sN4Y2 5uCXrDNjHGu8/74PWRGZNyP3yrCkuippAzhSBsKu9re0rAx+yvV7lcfKPuQg3BGG R4LYWC20UeoAEyIJQ3poKP+tavurP29lqxG4+w1KpMAdlRAilx4+wifaJiyw9HGt 4gDtapvR4gmMI/7ff0p5jr8QPXpbIjb8ljUrUxoXwS2xv/D//fB1U7NO1fMsLDBk /x1nluZDKNzcxADi/Vo7UNGEX6zKNMrFTwgUi0K7RvpyUAP4JddETIvu3fXqBRy7 xHgznv3eGmK1XJ8NXJxYTMR0DgTff7ZLjZKUBzsrgZivHwemstNfEgiu1/fM4Pbs UltX97oJj3GAVkXl9MvNDgYk3AJ+SHq15qoQw547k4ogHGANcSz6UqAjcQcsCSW5 yLwKxESFQB/1zU1gkv9rdhXoQOOUnxB+Nt2JnbUX8QUBXGN467PMnBJpYm3MChdO QOLij0kAHpL4Ofz7OtLiwqH+vlbI3njI0eHdrdkXWhcmsr3chDfh4RQLjyMinmyB 0nN/e0/TbrCSJIr3JmsBlt9quxfVw05FbI7Wz+IQC88/K9cYBQwpQQ3WPKAcyNYb JikuAPyKDA== =VMsf -----END PGP SIGNATURE----- --=-=-=--