From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master f51f963: Fix some side-effecting uses of make-text-button Date: Fri, 05 Jun 2020 14:51:17 +0100 Message-ID: <87tuzpmxii.fsf@tcd.ie> References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> <87eeqtiy4x.fsf@tcd.ie> <87img51y04.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="31693"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 15:52:57 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhCmH-00086E-3F for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 15:52:57 +0200 Original-Received: from localhost ([::1]:55484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhCmG-0001yr-5k for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 09:52:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhCkj-0000NW-D3 for emacs-devel@gnu.org; Fri, 05 Jun 2020 09:51:21 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:42561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhCki-0001eX-Lg for emacs-devel@gnu.org; Fri, 05 Jun 2020 09:51:21 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id p5so9830647wrw.9 for ; Fri, 05 Jun 2020 06:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=I0G3pQwFZm0gctm8dfQjSaWYFMdxnc2gyLogL64z7/o=; b=yCxFeBQhW07YZndCfSPLoTWeS36zwZoDAQ0PZi5TnZCjCr2MNGFSv7WIcFe0Qjmaj3 RCvVVqaqDLxiKMVk1nIl4mUoVk7qB6RGT6/lXVn+Jn05Z6x5PRN0fWDZDXJUWDOcY7Ox 2/qzHVoZEa3h7bY2DChK/6Yhb+64Xuk0pjYpsNA144McrcG4BdeI/e10yySgcLBBJbNW ue/hQ0tNQcdqB3xVyG0yWP765yf/9WngpptHVwo4UU6rnzYDp76/QLABBTEqGtkm3v1b /u9YVG+tzIihYtcC0jfRxAYZ3R1oTOg/pK2PKtej5lDbjtjDz3Sh784um2r/vy7DtvLH FWcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=I0G3pQwFZm0gctm8dfQjSaWYFMdxnc2gyLogL64z7/o=; b=I3998xBzK787Br67Ow4V2NMGDbe9+oH3Ctc7ZF3Gjbrfo5ULn2H/qYLiq8LgdpnQtL I2U7FA9FkhJjSgPhSgI1gPTzpkAW04EBzGAO5mg/N+q+t1czT6+fCvXOjzLwo8ek4cC4 EGjheP/6B8mixa8SzQZeZolZm9F9LEvKvrMuKygDlP0AI4jpouMCBIl6e54NSsb9tScA q+T0HVGCJO8WN6+WULxoIXnCT3rHLMK0eBeCJMCB+sqX9bSI+/uhATCEMh3ypsA62SxU awqGDLPWDpMQihI4W3WTbtNjD7uqZeb5UR5NQLxRbjCUV0Xdket4snEFYPHZsMwug00P wQbg== X-Gm-Message-State: AOAM532I7vbw2S/NhqxrQK7NikNpNv6iw2GT21aIwByfArAitJNK590T R9LChgk8LpxLShh6YF/vsQnrBw== X-Google-Smtp-Source: ABdhPJzb3Cs5CwDKjoFiuu6NkLj5okirca2VvfrCGjL2QWBqbbHoPvfLXd2DN/NThNTXB77jPw7uqA== X-Received: by 2002:a5d:4390:: with SMTP id i16mr9277085wrq.186.1591365079129; Fri, 05 Jun 2020 06:51:19 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id q1sm11018567wmc.15.2020.06.05.06.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 06:51:18 -0700 (PDT) In-Reply-To: <87img51y04.fsf@gmail.com> (Pip Cet's message of "Fri, 05 Jun 2020 12:46:19 +0000") Received-SPF: none client-ip=2a00:1450:4864:20::434; envelope-from=contovob@tcd.ie; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251897 Archived-At: Pip Cet writes: [...] > It would not be a quick bug fix for code that uses (propertize "string" > 'a 'b). propertize returns a copy of its argument, so it's not problematic in this context. > In particular, I'm not convinced code like that is buggy at all. It's > true that it will fail under certain conditions (the string constant is > used again in the same function, the function is byte compiled, that > sort of thing), and it's true there are better ways of doing that, but > is that reason enough to off-handedly ban all such code? [...] My only concern with destructively modifying string literals as in the (make-text-button "here" ...) example is that it can "pollute" that string literal for all of its users, which is both "rude" and unnecessary in this case. I simply find it cleaner, less intrusive, and less surprising to modify only one's own copy of a string in such a trivial case. I'm not personally concerned with crashes, theoretical purity or mutability, or anything like that; for that I defer to you, Paul, and other experts. -- Basil