From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 64e25cd: More robust NS hex colour string parsing Date: Fri, 12 Jun 2020 19:33:37 +0100 Message-ID: <87tuzgnnge.fsf@tcd.ie> References: <20200608120746.30163.87810@vcs0.savannah.gnu.org> <20200608120747.80E8E20A2E@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="75036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Pip Cet , emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 12 20:34:55 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjoVy-000JNl-Qa for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 20:34:54 +0200 Original-Received: from localhost ([::1]:58140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjoVx-0002Hm-Tr for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Jun 2020 14:34:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjoUr-0001lM-EN for emacs-devel@gnu.org; Fri, 12 Jun 2020 14:33:45 -0400 Original-Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37444) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjoUp-0001zS-7r for emacs-devel@gnu.org; Fri, 12 Jun 2020 14:33:45 -0400 Original-Received: by mail-wm1-x341.google.com with SMTP id y20so9164568wmi.2 for ; Fri, 12 Jun 2020 11:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cd9bsLZftWMWvkz1DxHmrWKmfFP4wCQ/lO7nfMqpLUI=; b=fxBA+JgNz51jCaNZP58Mp4ukTEkDP4ETCMcNVN391TXIDdzJHOEN4Brqh0pLtZi7RS RLCQ2tbB+AwHc/VHs0LmWtC6r/OHbAPO92b7TG6rN/5jP19N8vMocmgjOCebwRHf3biR JNgGhwIrp58XxJ2AVdnhfKElyQE+RLGYHbQLQYOiLjXCoa5igKnY8RjCi/JwXGUYozVO ZiME7QRwoxdsJMLUQgIBDWFxJHbgkHtMsclzVJ5TGj/r7Sr3Q3T2K6P/uDelb05mjasY yDRvmMbBGYs8uaMgNrJuv1XKwmqkF2Wto2XW8OZ+gF9s623HbH4SdzTS/RHmYSpm6pIm lqiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cd9bsLZftWMWvkz1DxHmrWKmfFP4wCQ/lO7nfMqpLUI=; b=WNZlq+5cy0MNX5Fw40+7rSbEL/eQoxxJ+9tzfNvniy8n6NAsopCxccr5Ldi+UlNGqd oYfqJvo1XpUl7htXJwyyH0YZKlbhB9v8UORgqSD2chm/NbkU2xGLjhXXvIkXiaF5Wz3U iEF8KZUA5tVT4zSF+9rAQfI6DDG356r89ADXPyvIwV+OEpE2k+YNh/B4Ik8glli8W2ir 8PiU4z3kZ197KVQyEt57NsEn9/yRGB+UK+MOTqDxFoBW+UvXTAIrmr2LuOPC8gyMIBpV 3nVIc0FNZ9298abyemqMgpaOZYPLc7J8B8KVhfL3CTOXZRIx5PD+k/HS4INfMIl2zzZ9 5onA== X-Gm-Message-State: AOAM532Y8M0ca9Auv7u5GbjkWktqeAbrEiJh+xIJYXOtQq/ZT1B0j9Aj jwhVuRMbwFzMf5S0NA4fahdlTw== X-Google-Smtp-Source: ABdhPJxh2PeTYU0sF8rXtwpT2EX3jwhGwfTqiHL3lYZk50fKU5PxiWXfbWoI6TAQOUQtOwO7CimyCQ== X-Received: by 2002:a7b:cb91:: with SMTP id m17mr265332wmi.126.1591986819539; Fri, 12 Jun 2020 11:33:39 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id f11sm11113648wrj.2.2020.06.12.11.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 11:33:38 -0700 (PDT) In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 12 Jun 2020 18:59:36 +0200") Received-SPF: none client-ip=2a00:1450:4864:20::341; envelope-from=contovob@tcd.ie; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252142 Archived-At: Mattias Engdeg=C3=A5rd writes: > Only really tested for NS; someone needs to check the X and Windows backe= nds. I get this warning: xterm.c:2379: warning: macro "HEX_COLOR_NAME_LENGTH" is not used [-Wunuse= d-macros] 2379 | #define HEX_COLOR_NAME_LENGTH 32 Otherwise seems to compile and run fine. I tried: 0. emacs -Q 1. M-x list-colors-display RET 2. M-x set-background-color RET #abc RET Is there something else I should be doing to test this? Thanks, --=20 Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo versio= n 1.16.0, Xaw3d scroll bars) of 2020-06-12 built on thunk Repository revision: 54efe18959591faa1087051c878abe470f53a28f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=3Dccache gcc' 'CFLAGS=3D-O2 -march=3Dnative' --config-cache --prefix=3D/home/blc/.local --with-x-toolkit=3Dlucid --with-file-notification=3Dyes --with-x' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP