Re: master 64e25cd: More robust NS hex colour string parsing

["Basil L. Contovounesios" <contovob@tcd.ie>]

Mattias Engdegård <mattiase@acm.org> writes:

> Only really tested for NS; someone needs to check the X and Windows backends.

I get this warning:

  xterm.c:2379: warning: macro "HEX_COLOR_NAME_LENGTH" is not used [-Wunused-macros]
   2379 | #define HEX_COLOR_NAME_LENGTH 32

Otherwise seems to compile and run fine.  I tried:

0. emacs -Q
1. M-x list-colors-display RET
2. M-x set-background-color RET #abc RET

Is there something else I should be doing to test this?

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2020-06-12 built on thunk
Repository revision: 54efe18959591faa1087051c878abe470f53a28f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --with-x-toolkit=lucid
 --with-file-notification=yes --with-x'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB
NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT
LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS
LIBSYSTEMD JSON PDUMPER LCMS2 GMP