From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? WAS: Re: Making Emacs more friendly to newcomers Date: Sat, 13 Jun 2020 20:31:58 +0100 Message-ID: <87tuzezrrl.fsf@tcd.ie> References: <87mu78huhx.fsf_-_@yahoo.com> <87k12bdgx7.fsf@yahoo.com> <87r1wi7a8o.fsf@yahoo.com> <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123477"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Emacs developers , Stefan Kangas , Dmitry Gutov To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 13 21:32:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkBtR-000W1t-1y for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 21:32:41 +0200 Original-Received: from localhost ([::1]:51038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkBtP-0000Pj-NJ for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Jun 2020 15:32:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkBsq-0008DG-BV for emacs-devel@gnu.org; Sat, 13 Jun 2020 15:32:05 -0400 Original-Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:43409) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkBso-0005Gn-CT for emacs-devel@gnu.org; Sat, 13 Jun 2020 15:32:04 -0400 Original-Received: by mail-wr1-x442.google.com with SMTP id l10so13157705wrr.10 for ; Sat, 13 Jun 2020 12:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=S45v45tf7Jv500Y4J+QH2m4F2yYnX0T6+REJzlIWOds=; b=ufuv710Eitho3G39UCb2f1FpgnWP192s5SE5Uhv1Z7W8Qgk0iYZX3JVZ5kH9MeE8N8 MDxGUdsgK/52/yzqhniLve6IVuDRlRlSfam+MeoOEGXUQvmZgwxOyrhI6+kzH5mqIXwC 2kk5DDfjUyU8Km4Nn4YQh1l3vJHciJnMdpD4wYe8HYihLl7SXGVgb1vDAFmQA5OierrE O6qnTctRzZlXMXHG+NI3TosdWUxGfhg5iAFy4EcFmkOo1wiAyzAB8iyLvPWenbEe3n6K RlkJfZkH1lOXHuKNQ6MJRfWbSEhLmuvbLnvhdNAUaOK7C1UcqwG359Rvgj5GLEkFriy8 f5SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=S45v45tf7Jv500Y4J+QH2m4F2yYnX0T6+REJzlIWOds=; b=ZoJ0whIvduXMWsbSD+OW7TFsWR2ZvQSvNLHxrkJrALzUVO5xG6dv2SoawOiIxaBnno +BgMFl6TEPypghSKfmN1vdn+tt/NELvOuowpI08WV09XJsjVTZD5wjA0xyZhrcmbOR6m W0aUz44xL8KQpehFSjKfWAqWtCf9I2cjZkcn1XniNnRlba1O2HN587f2Yfu7xP0d3wMF Wsg5FDqjA6l+Ayly7UHLh04OWcezgIZs3xzK/TtvIIZqsZXS1hR6oZzqI86VI8JIXGWz m+jGHW40vqN+408fOap1rha1k2f8MYmFtL6p7AX+3si1Kc05QkigDCegfavagHNKFr9Q KQbw== X-Gm-Message-State: AOAM5332SfiedxQqwxi/BrFx5cBkPAigjSuNJ8p+plLA8vNvrZLlFqIW 5PUO0wbFkZCXidbF1LN0bxlxXg== X-Google-Smtp-Source: ABdhPJyXSesE6a7aGusLgrQOgIwV1k2eG07rflOFYTNYMpirdrITDdxw770jk5f8ryBeyJgB6dvL2A== X-Received: by 2002:adf:f0d2:: with SMTP id x18mr20953269wro.250.1592076720585; Sat, 13 Jun 2020 12:32:00 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id q11sm16289460wrv.67.2020.06.13.12.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 12:31:59 -0700 (PDT) In-Reply-To: (Konstantin Kharlamov's message of "Sat, 13 Jun 2020 22:23:30 +0300") Received-SPF: none client-ip=2a00:1450:4864:20::442; envelope-from=contovob@tcd.ie; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252201 Archived-At: Konstantin Kharlamov writes: > FTR, I am all for having good commit messages. It is IMO a must have for any git > project. But having a list of function names with description for each does not > make one. FWIW, one great benefit of this list for me is that I can quickly 'git log --grep' for all commits that mention a particular definition. Doing the same with 'git log -G' is painfully slower and with a far lower signal:noise ratio. > Instead it should be an overview of what is done, why, and how. That, or at the very least linking to the relevant bug/thread discussions, is always a good thing to do and encouraged. > Suppose you have a patch that deduplicates the same code pattern across 34 > functions by factoring it out to a single short function. Do you really need > that list? No, in such cases there are shortcuts you can take, such as "all callers changed". > I mean, sure it's a fun fact to know, but you'll have to review diff > anyway. If anything, it only burdens you by forcing to check that each function > is on the list. Commit message should reveal the intention of the changes (and > perhaps, if OP thinks changes may raise questions, they should also write the > reasoning). And then a reviewer gotta check (in particular) this intention > matches the actual code. I doubt anyone disagrees with that. -- Basil