From: Juri Linkov <juri@linkov.net>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Jeff Norden <jnorden@math.tntech.edu>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: A question about overlays and performance.
Date: Fri, 31 Jul 2020 02:04:45 +0300 [thread overview]
Message-ID: <87tuxobo4y.fsf@mail.linkov.net> (raw)
In-Reply-To: <87sgdb3xx5.fsf@localhost> (Ihor Radchenko's message of "Wed, 29 Jul 2020 09:36:06 +0800")
>> Any chance to fix also bug#40808? It's still open because there is
>> no solution for isearching invisible text in org-mode.
>
> Thanks for pointing out this bug. Searching actually works fine on my
> feature branch + patched isearch (though it is actually an unintended
> side-effect). However, (setq isearch-lazy-count t) leaves the last
> headline open. I will need to investigate this.
Leaving the last headline open is a known bug fixed in
https://debbugs.gnu.org/40808#8
Here it's explaned:
"And also it fixes an old bug existed in previous Emacs versions
where lazy-highlight didn't update lazy-highlighting when a hidden outline
was automatically opened at the end of the file (I noticed this bug only now).
So the condition ‘(eq search-invisible 'open)’ fixes an old bug..."
>> The problem is that org-mode puts the text property 'invisible'
>> only when the link is scrolled into view, I guess it puts the property
>> using font-lock.
>>
>> So it seems org-mode needs to use font-lock-ensure on the line
>> with the next search hit before calling isearch-filter-predicate
>> on the found occurence.
>
> I am currently undecided about searchability of hidden text in links. Do
> I understand correctly that you prefer the hidden parts of links to be
> searchable? Either way is possible. If hidden parts are searchable, it
> will be even possible to show them temporarily.
The hidden parts of links should be searchable when the value of
'search-invisible' is 't' ("Match hidden text").
prev parent reply other threads:[~2020-07-30 23:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 16:40 A question about overlays and performance Jeff Norden
2020-07-25 16:53 ` Eli Zaretskii
2020-07-25 17:24 ` Jeff Norden
2020-07-25 17:29 ` Eli Zaretskii
2020-07-26 1:33 ` Ihor Radchenko
2020-07-26 13:56 ` Eli Zaretskii
2020-07-26 14:19 ` Ihor Radchenko
2020-07-26 14:44 ` Stefan Monnier
2020-07-27 11:20 ` Ihor Radchenko
2020-07-28 16:43 ` Jeff Norden
2020-07-28 16:58 ` Yuan Fu
2020-07-28 17:05 ` Eric Abrahamsen
2020-07-29 1:52 ` Ihor Radchenko
2020-07-30 18:21 ` Jeff Norden
2020-07-28 23:53 ` Juri Linkov
2020-07-29 1:36 ` Ihor Radchenko
2020-07-30 23:04 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuxobo4y.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jnorden@math.tntech.edu \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).