From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior Date: Mon, 03 Aug 2020 11:14:35 -0400 Organization: GNU Message-ID: <87tuxjvk10.fsf@gnu.org> References: <871rkr7pme.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23695"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: "Mingde (Matthew) Zeng" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 03 17:15:25 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2cBQ-00062k-Ig for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Aug 2020 17:15:24 +0200 Original-Received: from localhost ([::1]:60774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2cBP-00034p-LP for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Aug 2020 11:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2cAg-0002UP-IN for emacs-devel@gnu.org; Mon, 03 Aug 2020 11:14:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43667) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2cAg-00032A-78; Mon, 03 Aug 2020 11:14:38 -0400 Original-Received: from [2607:fea8:3fdf:f688::2] (port=39876 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k2cAf-0007FR-EJ; Mon, 03 Aug 2020 11:14:38 -0400 Mail-Followup-To: "Mingde (Matthew) Zeng" , emacs-devel@gnu.org, Lars Ingebrigtsen In-Reply-To: <871rkr7pme.fsf@gmail.com> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253413 Archived-At: --=-=-= Content-Type: text/plain Thanks for the patch, Matthew. I just noticed Lars installed 6f94c2405f4c82b63da19de89549aff1fad7e594 on master, changing erc-generate-new-buffer-name. Will your patch require adjusting to accommodate Lars's changes? Minor nits: - Please omit the "Signed-off-by:" from your commit messages to Emacs. - Consider dropping the second "* lisp/erc/erc.el" for (erc-cmd-JOIN), since the previous entry (erc-generate-new-buffer-name) was also a change to lisp/erc/erc.el. Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl8oKdsQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8l0UD/sEFyaQ/rmw39LLrD3J8TrbgwsPh8ytdCAe gUU+C8t0XQtupXhQd6dESHnouZRIRE7TMsnunPncd9tzx9+HxwAHo2ZIpOqYQqtC PMpgC+c2rlmzrQrl1tdfpgEjMJFE7/Ebuks5qh8raUAimwr25WZmKi4XpPecqTH+ kHddASP3bLL90R8b1rgvFQ1rJtNUF3VSSVEwZmJtHs/AMc0dKr92CrhyQBQ/E7Bl jA0tOVrU3N+P7XFm/fjHD8FrmE5P7Kujv/6/Iyobrc98eNmGB0DqYIXOL7j+rJBn xuj61wYPLXW+BSs7Np+jNEhKHbYaJya6GyfFPTIqWW0pTyM3u1aix7MaJt+Pqjdx 0ZMhZlwb3Cu86A8mcJ6JBSHPJEfTX9GAGFRVIAjqfFbGOlvRCKsZugYHpxYTIa3N YMtjkS8PqdSo2MgDKZFEA1H0957P0HLbwY3P1lH9PAWzIcl5GPVv5PiHTQPdL0eq szxcIQg6FaACEzCXBeQqhz1hj1wFFgQchQp415GePkYL6g2V4c6WpB8rHBeiFe+L FxyhdRbky+YtGl5Mh0z6PzY8GIQ2UZixEtIHI242Q3HY2eVWUTq77YfHrPYGmy9o B+oIVHQdkLE0EXmxofPUPn6pEAdhVItB0RTVVcVB5xc85LZbLW+dXW2bZVa3VPan jckThyJ52w== =NQzt -----END PGP SIGNATURE----- --=-=-=--