From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lev Lamberov Newsgroups: gmane.linux.debian.devel.emacsen,gmane.emacs.devel Subject: Re: seq.el: requesting an update to the version in GNU ELPA Date: Fri, 04 Sep 2020 15:46:21 +0500 Message-ID: <87tuwdes5e.fsf@localhost> References: <87d03al9lq.fsf@iris.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: debian-emacsen@lists.debian.org, 969103@bugs.debian.org To: Stefan Kangas , emacs-devel@gnu.org Original-X-From: bounce-debian-emacsen=debian-emacsen=m.gmane-mx.org@lists.debian.org Fri Sep 04 12:46:50 2020 Return-path: Envelope-to: debian-emacsen@m.gmane-mx.org Original-Received: from bendel.debian.org ([82.195.75.100]) by ciao.gmane.io with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kE9F4-0006dJ-Iq for debian-emacsen@m.gmane-mx.org; Fri, 04 Sep 2020 12:46:50 +0200 Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with QMQP id 5F97A20390; Fri, 4 Sep 2020 10:46:50 +0000 (UTC) X-Mailbox-Line: From debian-emacsen-request@lists.debian.org Fri Sep 4 10:46:50 2020 Old-Return-Path: Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with ESMTP id CCBD72038B for ; Fri, 4 Sep 2020 10:46:41 +0000 (UTC) X-Virus-Scanned: at lists.debian.org with policy bank en-lt X-Amavis-Spam-Status: No, score=-6.578 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, GMAIL=1, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001] autolearn=ham autolearn_force=no Original-Received: from bendel.debian.org ([127.0.0.1]) by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525) with ESMTP id N-EvZd0lNM_v for ; Fri, 4 Sep 2020 10:46:36 +0000 (UTC) X-policyd-weight: using cached result; rate: -4.6 Original-Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by bendel.debian.org (Postfix) with ESMTPS id AB84D20389 for ; Fri, 4 Sep 2020 10:46:35 +0000 (UTC) Original-Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4BjZ9M4nvKzFdxG; Fri, 4 Sep 2020 03:46:31 -0700 (PDT) X-Riseup-User-ID: A21FDED58B1A065ADC8DBB79896F5D30E07EBE4B2615D1251149E128AEE4DFE1 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 4BjZ9L14rCz8tRn; Fri, 4 Sep 2020 03:46:29 -0700 (PDT) In-Reply-To: X-Rc-Virus: 2007-09-13_01 X-Rc-Spam: 2008-11-04_01 Resent-Message-ID: Resent-From: debian-emacsen@lists.debian.org X-Mailing-List: archive/latest/6594 X-Loop: debian-emacsen@lists.debian.org List-Id: List-URL: List-Post: List-Help: List-Subscribe: List-Unsubscribe: Precedence: list Resent-Sender: debian-emacsen-request@lists.debian.org List-Archive: https://lists.debian.org/msgid-search/87tuwdes5e.fsf@localhost Resent-Date: Fri, 4 Sep 2020 10:46:50 +0000 (UTC) Xref: news.gmane.io gmane.linux.debian.devel.emacsen:5996 gmane.emacs.devel:254519 Archived-At: Hi Stefan, =D0=A1=D0=B1 29 =D0=B0=D0=B2=D0=B3 2020 @ 07:52 Stefan Kangas : > Stefan Kangas writes: > >> I have bumped the version of seq.el to 2.22 on the Emacs master branch. >> >> IIUC, the new version will be automatically picked up by the GNU ELPA >> scripts and available for installation within 24-48 hours. > > It turns out that seq.el is a special case where we have some > compatibility code for Emacs 24, so it needs manual intervention. > > The attached patch compiles without warnings on Emacs 26 and 27. > Unfortunately, I don't have Emacs 25 or 24 available for testing. > Could someone please help check that it's okay before I install it? Sorry for delay and thanks for your patch. I've applied your patch to seq from the ELPA git repository and tested it both in GNU Emacs 24 and GNU Emacs 25 from the Debian archive (stretch release). Here is the output: - GNU Emacs 24 $ emacs --version GNU Emacs 24.5.1 Copyright (C) 2015 Free Software Foundation, Inc. GNU Emacs comes with ABSOLUTELY NO WARRANTY. You may redistribute copies of Emacs under the terms of the GNU General Public License. For more information about these matters, see the file named COPYING. $ LANG=3DC.UTF-8 emacs -batch -L . -l tests/seq-tests.el --eval "(ert-run-t= ests-batch-and-exit)" Loading 00debian-vars... Running 34 tests (2020-09-04 10:36:18+0000) passed 1/34 test-seq-concatenate passed 2/34 test-seq-contains passed 3/34 test-seq-count passed 4/34 test-seq-difference passed 5/34 test-seq-drop passed 6/34 test-seq-drop-while passed 7/34 test-seq-empty-p passed 8/34 test-seq-every-p passed 9/34 test-seq-filter passed 10/34 test-seq-find passed 11/34 test-seq-group-by passed 12/34 test-seq-intersection passed 13/34 test-seq-into passed 14/34 test-seq-into-and-identity passed 15/34 test-seq-let passed 16/34 test-seq-map-indexed passed 17/34 test-seq-mapcat passed 18/34 test-seq-mapn passed 19/34 test-seq-mapn-circular-lists passed 20/34 test-seq-min-max passed 21/34 test-seq-partition passed 22/34 test-seq-position passed 23/34 test-seq-random-elt-signal-on-empty passed 24/34 test-seq-random-elt-take-all passed 25/34 test-seq-reduce passed 26/34 test-seq-remove passed 27/34 test-seq-reverse passed 28/34 test-seq-some passed 29/34 test-seq-sort passed 30/34 test-seq-sort-by passed 31/34 test-seq-subseq passed 32/34 test-seq-take passed 33/34 test-seq-take-while passed 34/34 test-seq-uniq Ran 34 tests, 34 results as expected (2020-09-04 10:36:18+0000) - GNU Emacs 25 $ emacs --version GNU Emacs 25.1.1 Copyright (C) 2016 Free Software Foundation, Inc. GNU Emacs comes with ABSOLUTELY NO WARRANTY. You may redistribute copies of GNU Emacs under the terms of the GNU General Public License. For more information about these matters, see the file named COPYING. $ LANG=3DC.UTF-8 emacs -batch -L . -l tests/seq-tests.el --eval "(ert-run-t= ests-batch-and-exit)" Loading 00debian-vars... seq-25.el: =E2=80=98seq-contains=E2=80=99 is an obsolete generic function (= as of 27.1); use =E2=80=98seq-contains-p=E2=80=99 instead. Running 34 tests (2020-09-04 10:41:15+0000) passed 1/34 test-seq-concatenate passed 2/34 test-seq-contains passed 3/34 test-seq-count passed 4/34 test-seq-difference passed 5/34 test-seq-drop passed 6/34 test-seq-drop-while passed 7/34 test-seq-empty-p passed 8/34 test-seq-every-p passed 9/34 test-seq-filter passed 10/34 test-seq-find passed 11/34 test-seq-group-by passed 12/34 test-seq-intersection passed 13/34 test-seq-into passed 14/34 test-seq-into-and-identity passed 15/34 test-seq-let passed 16/34 test-seq-map-indexed passed 17/34 test-seq-mapcat passed 18/34 test-seq-mapn passed 19/34 test-seq-mapn-circular-lists passed 20/34 test-seq-min-max passed 21/34 test-seq-partition passed 22/34 test-seq-position passed 23/34 test-seq-random-elt-signal-on-empty passed 24/34 test-seq-random-elt-take-all passed 25/34 test-seq-reduce passed 26/34 test-seq-remove passed 27/34 test-seq-reverse passed 28/34 test-seq-some passed 29/34 test-seq-sort passed 30/34 test-seq-sort-by passed 31/34 test-seq-subseq passed 32/34 test-seq-take passed 33/34 test-seq-take-while passed 34/34 test-seq-uniq Ran 34 tests, 34 results as expected (2020-09-04 10:41:15+0000) Cheers! Lev