From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Address issue with tab-bar Date: Fri, 18 Sep 2020 11:29:17 +0300 Organization: LINKOV.NET Message-ID: <87tuvvplqe.fsf@mail.linkov.net> References: <87o8m4o1ti.fsf@gmail.com> <87een0nrza.fsf@mail.linkov.net> <87zh5oi2ma.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: James N. V. Cash Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 10:33:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJBpO-0006eY-RV for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 10:33:10 +0200 Original-Received: from localhost ([::1]:50918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJBpN-0003sm-Sa for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 04:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJBne-0002XJ-1U for emacs-devel@gnu.org; Fri, 18 Sep 2020 04:31:23 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJBnc-00069t-AB for emacs-devel@gnu.org; Fri, 18 Sep 2020 04:31:21 -0400 X-Originating-IP: 91.129.108.13 Original-Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CC90C1C0003; Fri, 18 Sep 2020 08:31:16 +0000 (UTC) In-Reply-To: <87zh5oi2ma.fsf@gmail.com> (James N. V. Cash's message of "Thu, 17 Sep 2020 16:12:45 -0400") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 04:31:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256062 Archived-At: >> So the problem is that tab-bar-new-tab doesn't show the tab-bar again >> when there are more than one tab. > > Ah, in that case, I think we can just remove the first case in the cond > in tab-bar-new-tab-to; simple patch attached > > diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el > index d8f932e7a4..e4b3c8cf19 100644 > --- a/lisp/tab-bar.el > +++ b/lisp/tab-bar.el > @@ -801,7 +801,6 @@ tab-bar-new-tab-to > (nth to-index tabs))) > > (cond > - (tab-bar-mode) > ((eq tab-bar-show t) > (tab-bar-mode 1)) > ((and (natnump tab-bar-show) Thanks for the fix, now pushed.