unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: James N. V. Cash <james.cash@occasionallycogent.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Address issue with tab-bar
Date: Fri, 18 Sep 2020 11:29:17 +0300	[thread overview]
Message-ID: <87tuvvplqe.fsf@mail.linkov.net> (raw)
In-Reply-To: <87zh5oi2ma.fsf@gmail.com> (James N. V. Cash's message of "Thu, 17 Sep 2020 16:12:45 -0400")

>> So the problem is that tab-bar-new-tab doesn't show the tab-bar again
>> when there are more than one tab.
>
> Ah, in that case, I think we can just remove the first case in the cond
> in tab-bar-new-tab-to; simple patch attached
>
> diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
> index d8f932e7a4..e4b3c8cf19 100644
> --- a/lisp/tab-bar.el
> +++ b/lisp/tab-bar.el
> @@ -801,7 +801,6 @@ tab-bar-new-tab-to
>                            (nth to-index tabs)))
>
>      (cond
> -     (tab-bar-mode)
>       ((eq tab-bar-show t)
>        (tab-bar-mode 1))
>       ((and (natnump tab-bar-show)

Thanks for the fix, now pushed.



      reply	other threads:[~2020-09-18  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 15:33 [PATCH] Address issue with tab-bar James N V Cash
2020-09-17 19:07 ` Juri Linkov
2020-09-17 20:12   ` James N. V. Cash
2020-09-18  8:29     ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuvvplqe.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=james.cash@occasionallycogent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).