From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master d067ac5: Remove more compat code from prolog.el Date: Fri, 25 Sep 2020 15:49:30 +0200 Message-ID: <87tuvmnez9.fsf@gnus.org> References: <20200925093755.19433.41297@vcs0.savannah.gnu.org> <20200925093756.C7849209D4@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34001"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 25 15:52:25 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLo9A-0008jh-Vz for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 15:52:24 +0200 Original-Received: from localhost ([::1]:46680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLo99-0006oj-UA for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 09:52:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLo6V-0003JR-7S for emacs-devel@gnu.org; Fri, 25 Sep 2020 09:49:39 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLo6T-0000o5-FU for emacs-devel@gnu.org; Fri, 25 Sep 2020 09:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZcUxnkP0YJR0TzV2WKZmhmMNw3WII58q34JZFoQRMSo=; b=jYvMOsQLqjlwJXEJ1rqETsE15l CxtA/PKup33U5zEzbnLul/ymHw89VINhHKFNxgqVSlKcotGNBelyKG1ysUGhZq06VlgSxBpjHlMez e6yqrLUAlHnGAbVbbi2d/402u4zV5+O47Njo6sVw89nAQhIuA3Fr9zfm67yvyFMCTR4k=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLo6N-0002uh-FZ; Fri, 25 Sep 2020 15:49:34 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX39fC+tZ9tWU3/ //8CvaVvAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QJGQ0sCSk1yQkAAAFkSURBVCjPNZLBasMwDIbl UQfWUwvxoHmEPIXzBs6oA81tsJbFT5PCvMNOPaSj1lPul9qaHPTFf6RfUohc4l9mJho9Ccghw578 FlHiEtNCRG+MSJ4Z0DLjXRpuiCkJVEUvBC6ifcJsSmJ6wHlEkidk1iQ4W14MYHZ7wIm9QHfwIitk fpjthNin4s3SLpMU9aerp9DkqA5OGeJq8JLOt+cAt0ul8DYjp9s3AsEFR3TotB0ywe5d6ljNbYKJ iSOzFK1X2tK9h9pSA2jv8KrQqO9N5StApeBiRtOBWPzs4jRyJlKnNjZSw7pJZVYUXUyAo6UR33ZX qbqxtAbsBi1kfIM5xVFz3yEkHZ2BSar7P/W9BQQXdXsufsCN3SkcV3DDxil8RlHEOCikLCvOLypL RWDpZUVTKnDKt34AfLVFtlDCu9ygvlx997A9rYvsF7oRUF10l5wjvBsMvpLfB/3sdMYPOFL9hH8d tb3wT/8JUwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOS0yNVQxMzo0NDowOSswMDowMHDVrW0A AAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDktMjVUMTM6NDQ6MDkrMDA6MDABiBXRAAAAAElFTkSu QmCC X-Now-Playing: Stephan Mathieu's _FrequencyLib_: "Right Place" In-Reply-To: (Stefan Monnier's message of "Fri, 25 Sep 2020 08:39:23 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256429 Archived-At: Stefan Monnier writes: >> @@ -1999,7 +1997,7 @@ Argument BOUND is a buffer position limiting searching." >> (if (eq prolog-system 'mercury) >> (list >> (regexp-opt prolog-directives-i 'words) >> - 0 'prolog-warning-face))) >> + 0 prolog-warning-face))) >> ;; Inferior mode specific patterns >> (prompt >> ;; FIXME: Should be handled by comint already. > > I think this one is wrong: the font-lock data-structure built here > should contain at this position an *expression* that returns a face when > passed to `eval`. > > IOW with the above change the value held by `prolog-warning-face` needs > to be "an expression that evaluates to a face" rather than "a face name". All the other places there used the variable instead of the symbol, I think? For instance: ;; FIXME: Add to compilation-error-regexp-alist instead. (cond ((eq prolog-system 'sicstus) '("[ \t]*[0-9]+[ \t]+[0-9]+[ \t]*\\(Fail\\):" 1 prolog-warning-face)) ((eq prolog-system 'swi) '("[ \t]*\\(Fail\\):[ \t]*([ \t0-9]*)" 1 prolog-warning-face)) So I was just trying to make it more consistent. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no