From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Xref completion Date: Sat, 05 Dec 2020 21:52:32 +0200 Organization: LINKOV.NET Message-ID: <87tut0i39j.fsf@mail.linkov.net> References: <873617ets1.fsf@ambrevar.xyz> <878sazzsw5.fsf@mail.linkov.net> <7593e751-cff0-7c1a-7d4c-f927a16c07c9@yandex.ru> <3b255b14-6494-99dc-1e78-9607e0d1fcd9@yandex.ru> <87tut351ea.fsf@mail.linkov.net> <9bbe9827-8e96-e45c-2e0f-23a4fb5aea33@yandex.ru> <87pn3q8ulz.fsf@mail.linkov.net> <7e7e6923-851f-c1c0-4816-d84debe6570b@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: William Xu , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 05 20:55:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kldei-0005Hn-Vd for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 20:55:44 +0100 Original-Received: from localhost ([::1]:50820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kldei-0005dJ-1c for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 14:55:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kldcN-0004DY-Nz for emacs-devel@gnu.org; Sat, 05 Dec 2020 14:53:20 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kldcL-0005tm-E4 for emacs-devel@gnu.org; Sat, 05 Dec 2020 14:53:19 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 35FFAFF802; Sat, 5 Dec 2020 19:53:10 +0000 (UTC) In-Reply-To: <7e7e6923-851f-c1c0-4816-d84debe6570b@yandex.ru> (Dmitry Gutov's message of "Sat, 5 Dec 2020 03:12:43 +0200") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260387 Archived-At: > I've pushed it now with some changes, hope you all like the result. > > Shortening the group part (in most common cases) is among them. > > Also added some highlighting with corresponding xref faces. It now looks > closer to Pierre's original screenshot. Thanks, everything works well. Would be nicer to add all available choices to xref-show-definitions-function (i.e. "at bottom", "minibuffer"). > BTW, Juri, how do you think this new function compares against > xref--show-defs-buffer-at-bottom? > > On the one hand, it feels kinda faster, on the other, it lacks the ability > to "look around" when you really need it. In an ideal world, I guess the UI > would be somewhere in the middle. There are still too many differences between them. The most noteworthy is that xref--show-defs-minibuffer doesn't show completions by default, only after TAB TAB.