From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Little improvements on pulse.el Date: Wed, 10 Mar 2021 19:18:25 +0200 Organization: LINKOV.NET Message-ID: <87tupjort6.fsf@mail.linkov.net> References: <83ft13p5ow.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13477"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gabriel , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 10 18:25:02 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK2Zx-0003Kw-U5 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 18:25:01 +0100 Original-Received: from localhost ([::1]:50978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK2Zv-00006g-Fy for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Mar 2021 12:24:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK2UA-00020r-AW for emacs-devel@gnu.org; Wed, 10 Mar 2021 12:19:02 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:53901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK2U8-0004Cd-4X; Wed, 10 Mar 2021 12:19:02 -0500 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 5B01E100005; Wed, 10 Mar 2021 17:18:54 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Wed, 10 Mar 2021 05:41:45 -0800") Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266286 Archived-At: > Eli Zaretskii writes: > >>> 2. The name and the docstring mention the use with hooks, but would be >>> nice to use with advices as well. For example, to highlight the current >>> line when the cursor, buffer or window changes: > [...] >> >> I'd prefer not to use advices for such a simple job. For example, how >> about defining a new hook, which will receive the argument(s) you want >> to pass it? > > Besides the implementation details, how about packing this up in a > global minor mode, like `pulse-change-window-mode' or something? > I could see myself using something like that. Maybe simply something like: (defun pulse-line (&rest _) (pulse-momentary-highlight-one-line (point))) (add-hook 'window-state-change-functions #'pulse-line) or (add-hook 'window-configuration-change-hook #'pulse-line)