From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Mon, 05 Apr 2021 01:48:20 +0300 Organization: LINKOV.NET Message-ID: <87tuold7or.fsf@mail.linkov.net> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3211"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 05 01:05:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTBoW-0000i4-Ce for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 01:05:52 +0200 Original-Received: from localhost ([::1]:55912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTBoV-0002VS-Cr for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Apr 2021 19:05:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTBne-000259-KL for emacs-devel@gnu.org; Sun, 04 Apr 2021 19:04:58 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTBnc-0005cy-48 for emacs-devel@gnu.org; Sun, 04 Apr 2021 19:04:58 -0400 X-Originating-IP: 91.129.107.223 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B2004FF803; Sun, 4 Apr 2021 23:04:49 +0000 (UTC) In-Reply-To: <20210403001539.x4rb55dvh46rmhb3@Ergus> (Ergus's message of "Sat, 3 Apr 2021 02:15:39 +0200") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267397 Archived-At: --=-=-= Content-Type: text/plain > 1) Are there any option to move the cursor to the start of the candidate > after the search? I see that there is an isearch-other-end. But it is > not a custom but an internal variable. Now I am using a hook but it > seems a bit hacky. I agree that isearch-mode-end-hook should be customizable. Then initially we could provide at least one choice - a hook to move to isearch-other-end on exit: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=isearch-move-to-other-end.patch diff --git a/lisp/isearch.el b/lisp/isearch.el index 943e24aa56..c924b73607 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -178,10 +178,13 @@ isearch-mode-hook (defvar isearch-update-post-hook nil "Function(s) to call after isearch has found matches in the buffer.") -(defvar isearch-mode-end-hook nil +(defcustom isearch-mode-end-hook nil "Function(s) to call after terminating an incremental search. When these functions are called, `isearch-mode-end-hook-quit' -is non-nil if the user quits the search.") +is non-nil if the user quits the search." + :type 'hook + :options '(isearch-exit-other-end) + :version "28.1") (defvar isearch-mode-end-hook-quit nil "Non-nil while running `isearch-mode-end-hook' if the user quits the search.") @@ -1417,6 +1420,15 @@ isearch-done (and (not edit) isearch-recursive-edit (exit-recursive-edit))) +(defun isearch-exit-other-end () + "Move point to the beginning of the found search string. +Can be used in `isearch-mode-end-hook' or interactively to exit isearch." + (interactive) + (when isearch-mode + (isearch-exit)) + (when isearch-other-end + (goto-char isearch-other-end))) + (defvar isearch-mouse-commands '(mouse-minor-mode-menu) "List of mouse commands that are allowed during Isearch.") --=-=-= Content-Type: text/plain > 2) I want to disable wrapping and I see that there is an > `isearch-wrap-function` but it is a variable not a custom and it is not > documented in detail what is expected to be there. isearch-wrap-function could be customizable in the same way with 3 options: pause before wrapping (default), no pause, no warp at all. > 3) In general many of the customizable variables in isearch are defined > with defvar so it is difficult to distinguish between internal and user > exposed ones. Just to mention some examples: > isearch-push-state-function, isearch-filter-predicate, the hooks, And these as well. > Are there any WIP related? There is no WIP until you create a feature request. --=-=-=--