* Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition. [not found] ` <20210715092412.6EC9720D13@vcs0.savannah.gnu.org> @ 2021-07-15 11:53 ` Stefan Kangas 2021-07-15 14:16 ` Eli Zaretskii 0 siblings, 1 reply; 3+ messages in thread From: Stefan Kangas @ 2021-07-15 11:53 UTC (permalink / raw) To: Emacs developers, Eli Zaretskii Eli Zaretskii <eliz@gnu.org> writes: > *** New function 'split-string-shell-command'. > -This splits a shell string into separate components, respecting single > -and double quotes, as well as backslash quoting. > +This splits a shell command string into separate components, > +respecting quoting with single ('like this') and double ("like this") > +quotes, as well as backslash quoting (like\ this). Arguably nit-picking, but would it better to say "a string containing a shell command"? It could be unclear here what a "shell command string" is; a reader might believe it's a special string type. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition. 2021-07-15 11:53 ` master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition Stefan Kangas @ 2021-07-15 14:16 ` Eli Zaretskii 2021-07-15 14:38 ` Andreas Schwab 0 siblings, 1 reply; 3+ messages in thread From: Eli Zaretskii @ 2021-07-15 14:16 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel > From: Stefan Kangas <stefan@marxist.se> > Date: Thu, 15 Jul 2021 13:53:20 +0200 > > Eli Zaretskii <eliz@gnu.org> writes: > > > *** New function 'split-string-shell-command'. > > -This splits a shell string into separate components, respecting single > > -and double quotes, as well as backslash quoting. > > +This splits a shell command string into separate components, > > +respecting quoting with single ('like this') and double ("like this") > > +quotes, as well as backslash quoting (like\ this). > > Arguably nit-picking, but would it better to say "a string containing > a shell command"? It could be unclear here what a "shell command > string" is; a reader might believe it's a special string type. "A string containing SOMETHING" sounds strange to me. In particular, it could be interpreted to mean the string contains something else, in addition to the shell command. "Shell command string" is a string that is a shell command. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition. 2021-07-15 14:16 ` Eli Zaretskii @ 2021-07-15 14:38 ` Andreas Schwab 0 siblings, 0 replies; 3+ messages in thread From: Andreas Schwab @ 2021-07-15 14:38 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Stefan Kangas, emacs-devel On Jul 15 2021, Eli Zaretskii wrote: >> From: Stefan Kangas <stefan@marxist.se> >> Date: Thu, 15 Jul 2021 13:53:20 +0200 >> >> Eli Zaretskii <eliz@gnu.org> writes: >> >> > *** New function 'split-string-shell-command'. >> > -This splits a shell string into separate components, respecting single >> > -and double quotes, as well as backslash quoting. >> > +This splits a shell command string into separate components, >> > +respecting quoting with single ('like this') and double ("like this") >> > +quotes, as well as backslash quoting (like\ this). >> >> Arguably nit-picking, but would it better to say "a string containing >> a shell command"? It could be unclear here what a "shell command >> string" is; a reader might believe it's a special string type. > > "A string containing SOMETHING" sounds strange to me. In particular, > it could be interpreted to mean the string contains something else, in > addition to the shell command. "Shell command string" is a string > that is a shell command. It is a string that is treated as a shell command. What the string actually contains isn't the point. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-15 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210715092410.26215.24260@vcs0.savannah.gnu.org>
[not found] ` <20210715092412.6EC9720D13@vcs0.savannah.gnu.org>
2021-07-15 11:53 ` master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition Stefan Kangas
2021-07-15 14:16 ` Eli Zaretskii
2021-07-15 14:38 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).