From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line: New tab-line-tab-face-modified face Date: Fri, 24 Sep 2021 02:09:34 -0500 Message-ID: <87tuiabgb5.fsf@alphapapa.net> References: <87bl4id10a.fsf@alphapapa.net> <87pmsyo4uz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26100"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 24 09:11:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTfMZ-0006WU-I0 for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Sep 2021 09:11:15 +0200 Original-Received: from localhost ([::1]:54682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTfMX-0003Gs-GY for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Sep 2021 03:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTfLA-0001YA-2p for emacs-devel@gnu.org; Fri, 24 Sep 2021 03:09:48 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:38824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTfL8-0003CD-AD for emacs-devel@gnu.org; Fri, 24 Sep 2021 03:09:47 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mTfL5-0004h6-L9 for emacs-devel@gnu.org; Fri, 24 Sep 2021 09:09:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275386 Archived-At: Juri Linkov writes: >> Spending some more time using Emacs 28.0.50 with tab-bar and tab-line, I >> found myself missing the ability to look at a tab-line tab and know >> whether its buffer is modified (e.g. after using >> `xref-query-replace-in-results' on some project buffers). >> >> This patch adds a face for modified, file-backed buffers. I chose to >> inherit from the font-lock-doc-face, as it seems readable and intuitive >> with the default theme. It seems to make the tab-line much more useful, >> and more in line with what users will probably expect from having used >> other editors' GUIs. > > Thanks, a modified buffer needs to be indicated somehow, > but all other editors' GUIs display ‘*’ at the beginning > of the modified buffer's name. Some do, yes, but I've used some that change the appearance of the text in the tab's name, e.g. making it bold, italic, etc. We already use italic for non-file-backed buffers, and bold seems, well, too bold, IMHO (and it may change the width of the tab with proportional fonts), so changing the color seems reasonable. I'm not opposed to optionally adding an asterisk to the name, but that would change the width of the tab as soon as a user types into a buffer, which doesn't seem like a good default to me.