From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Gregory Heytings <gregory@heytings.org>, emacs-devel@gnu.org
Subject: Re: master daea9b3 1/2: Read mailcaps again only when necessary
Date: Mon, 01 Nov 2021 18:01:56 +0100 [thread overview]
Message-ID: <87tugvrerf.fsf@gnus.org> (raw)
In-Reply-To: <jwvfssfu8by.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 01 Nov 2021 12:56:37 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> If two packages read&parse the same file and both rely on this function
> to decide when to reparse, the second package can get a nil value
> (because the first has caused the mtime to be reset in the hash table)
> even though the file has changed since it last parsed it.
I think that's up to the higher level to decide whether it's a problem
or not, like with other memoizing functions.
(And relatedly, this function shouldn't use file-truename or anything on
the filename -- it's a string used as the key.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-01 17:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211101135344.25800.81476@vcs0.savannah.gnu.org>
[not found] ` <20211101135346.2EBEB20B72@vcs0.savannah.gnu.org>
2021-11-01 16:56 ` master daea9b3 1/2: Read mailcaps again only when necessary Stefan Monnier
2021-11-01 17:01 ` Lars Ingebrigtsen [this message]
2021-11-01 17:19 ` Eli Zaretskii
2021-11-01 17:21 ` Lars Ingebrigtsen
2021-11-01 17:24 ` Eli Zaretskii
2021-11-01 17:29 ` Lars Ingebrigtsen
2021-11-01 18:13 ` Eli Zaretskii
2021-11-01 18:35 ` Stefan Monnier
2021-11-01 18:56 ` Eli Zaretskii
2021-11-01 21:07 ` Stefan Monnier
2021-11-02 12:54 ` Eli Zaretskii
2021-11-02 13:51 ` Stefan Monnier
2021-11-01 18:20 ` Stefan Monnier
2021-11-01 18:31 ` Eli Zaretskii
2021-11-01 18:06 ` Stefan Monnier
2021-11-01 18:48 ` Lars Ingebrigtsen
2021-11-01 18:50 ` Stefan Monnier
2021-11-01 19:04 ` Lars Ingebrigtsen
2021-11-01 21:31 ` Stefan Monnier
2021-11-02 14:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tugvrerf.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).