From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: repeat-mode: Setting `repeat-map' property to a keymap object fails Date: Thu, 25 Nov 2021 19:34:55 +0100 Message-ID: <87tug03wz4.fsf@gmail.com> References: <87tug1qoej.fsf@gmail.com> <86y25cvf6p.fsf@mail.linkov.net> <875ysg1509.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Narendra Joshi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 25 19:37:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqJcJ-0003wP-H5 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 19:37:07 +0100 Original-Received: from localhost ([::1]:54472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqJcH-00010a-Di for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 13:37:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqJaG-0007Xj-Eo for emacs-devel@gnu.org; Thu, 25 Nov 2021 13:35:00 -0500 Original-Received: from [2a00:1450:4864:20::434] (port=38870 helo=mail-wr1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqJaE-0004d8-Ih for emacs-devel@gnu.org; Thu, 25 Nov 2021 13:35:00 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id u18so13530145wrg.5 for ; Thu, 25 Nov 2021 10:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=o+aoyec/w+p0B15qSm3liAQnid8awfqj40FGyn266cI=; b=bhJerV0+9mNW+k7Ga6JgSKlA5kjXxqojNNGSN23l0FYqmJpuG+2hxTcXA28zAqoXPg WG/FBSQMGVIbfLWaemrmSxlsaeHUFTo9u4Z1plyXhRiWEMVvB8It/A74DkkcVxTkPRt+ ibuwnbsBs2SvWghHlj6C4Wc3rqySVTsV+Jwvc9vMuITmKHwt6wrGCnkvhHv/tJJU4oTz 37y4ddAfgQiqn0FNxhOGvJGGS2SlKor9gJAR41AaOYn+CICoN2dj6FrG5l/tF8u5mGAl 3aox4orizOt5sB9PsC8m1GWgOaFTyAd7Op8xQI3/YPuC255SChT+tIYrnOuWbrVzRryF 4lpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=o+aoyec/w+p0B15qSm3liAQnid8awfqj40FGyn266cI=; b=Lb3UQIuvpGZaxu72ybMco8/jVO6eRb7XXQXJ0P/qY6qfhoRf6ubmeL6fA7CPA2RrGG 02cmfKb0mdWjBqcLLsT/ip7a80CJQzGSDxkrCFVkVB5be6QlsqPa85dT6gfwjFWbkMZA 83mRvhhyNlbvGq/bFfIWByA2bWOuLPGsi4VHnk6d1zQUdNRkxEvn0a94wpjF2wL8ll3K ZVq0hNXgZbVQhMCldJeOr7KtGGZwtsUje4MDWWySu4WWhSq5U78bpvmLfKIeNabjed4/ qXKZzl7VpNYMy2r34VhIzQJcU1JqyBjdtDLP/3GNdf6wHWPF7EMLwjuygfTlSoYPyjxf ytaA== X-Gm-Message-State: AOAM530HfcMQJfju617wd1srA99Y71HUyml+h9SEu2xhLC4DsrfTZuET jAfsMvbJyD2Fvp6agfq7CjV+aRnJSUs= X-Google-Smtp-Source: ABdhPJxSsMwD/z5whpuFFFmPfurYxacqjOW2CnV4qnT3+/n0NGU/Xtm77Ff753nSBEbhdWlF9kwbDw== X-Received: by 2002:adf:fe8b:: with SMTP id l11mr9185767wrr.228.1637865296813; Thu, 25 Nov 2021 10:34:56 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:e24a:add5:5ee1:31a8]) by smtp.gmail.com with ESMTPSA id bg12sm4795720wmb.5.2021.11.25.10.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 10:34:56 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <875ysg1509.fsf@gmail.com> (Narendra Joshi's message of "Thu, 25 Nov 2021 19:09:42 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::434 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=rpluim@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280171 Archived-At: >>>>> On Thu, 25 Nov 2021 19:09:42 +0100, Narendra Joshi said: Narendra> Juri Linkov writes: >>> I tried to use a `keymap' object as the value of the `repeat-map' >>> property of a symbol/command and it failed. I think the change below >>> would avoid the problem. The problem is that `boundp` throws an error >>> for anything other than a symbol value. >>> >>> diff --git a/lisp/repeat.el b/lisp/repeat.el >>> index 4dcd353e34..32ffb1884f 100644 >>> --- a/lisp/repeat.el >>> +++ b/lisp/repeat.el >>> @@ -416,7 +416,7 @@ repeat-post-hook >>> (and (symbolp real-this-command) >>> (get real-this-command 'repeat-map))))) >>> (when rep-map >>> - (when (boundp rep-map) >>> + (when (and (symbolp rep-map) (boundp rep-map)) >>> (setq rep-map (symbol-value rep-map))) >>> (let ((map (copy-keymap rep-map))) >> >> Thanks, fixed now. >> Narendra> Thanks. I see that it's merged to `emacs-28`. How/when would it end up Narendra> on the master branch? I am just curious about the overall process. emacs-28 is merged to master regularly by intrepid volunteers. Sometimes daily, sometimes weekly. Robert --