unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Madhu <enometh@meer.net>
Cc: rudalics@gmx.at,  masm+emacs@masm11.me,  emacs-devel@gnu.org,
	Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: Deiconifying GTK frames on GNOME shell
Date: Thu, 09 Dec 2021 10:46:27 +0800	[thread overview]
Message-ID: <87tufibim4.fsf@yahoo.com> (raw)
In-Reply-To: <20211209.080039.470925087338567275.enometh@meer.net> (Madhu's message of "Thu, 09 Dec 2021 08:00:39 +0530 (IST)")

Madhu <enometh@meer.net> writes:

> *  Po Lu <luangruo@yahoo.com> <87ilvyd3kd.fsf@yahoo.com>
> Wrote on Thu, 09 Dec 2021 08:28:34 +0800
>
>> Thanks, but could you test with GDK_CURRENT_TIME as the `time' argument
>> to `gtk_window_present_with_time'?
>
> It doesn't seem to work. The gitlab gnome-shell issue #730 seems to
> think it is a GTK issue

Then I think your patch is OK, bar some formatting problems: sentences
in commit messages aside from the title should end with punctuation, and
you should try to keep code within 70 columns.

It should be exempt from copyright assignment, adding or changing less
than 15 lines of code, but you may have exceeded that limit already.

Eli or Lars, has Madhu completed the copyright assignment?  And if not,
is this change exempt from copyright assignment?  Thanks.



  reply	other threads:[~2021-12-09  2:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05  9:39 Deiconifying GTK frames on GNOME shell martin rudalics
2021-09-05 10:26 ` Colin Baxter
2021-09-06  8:31   ` martin rudalics
2021-09-05 19:19 ` Dmitry Gutov
2021-09-06  8:32   ` martin rudalics
2021-09-07  0:45     ` Dmitry Gutov
2021-09-07  8:16       ` martin rudalics
2021-09-09 13:13         ` Madhu
2021-09-10  8:34           ` martin rudalics
2021-09-10 12:04             ` Madhu
2021-09-11  8:38               ` martin rudalics
2021-12-06 15:35                 ` Madhu
2021-12-08 11:00                   ` martin rudalics
2021-12-08 11:09                     ` Po Lu
2021-12-08 16:02                       ` Yuuki Harano
2021-12-09  0:28                         ` Po Lu
2021-12-09  2:30                           ` Madhu
2021-12-09  2:46                             ` Po Lu [this message]
2021-12-09  9:20                               ` Eli Zaretskii
2021-12-08 16:33                       ` Madhu
2021-12-09  0:31                         ` Po Lu
2021-12-09  2:33                           ` Madhu
2021-09-10  8:33       ` martin rudalics
2021-09-11 14:48         ` Dmitry Gutov
2021-09-11 16:43           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tufibim4.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=enometh@meer.net \
    --cc=larsi@gnus.org \
    --cc=masm+emacs@masm11.me \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).