unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: emacs-28 6170c50: Fix regression in help-mode prompt
       [not found] ` <20211213135230.17FE620A0A@vcs0.savannah.gnu.org>
@ 2021-12-14 11:30   ` Stefan Kangas
  2021-12-14 12:47     ` Colin Baxter 😺
  2021-12-14 13:09     ` Eli Zaretskii
  0 siblings, 2 replies; 11+ messages in thread
From: Stefan Kangas @ 2021-12-14 11:30 UTC (permalink / raw)
  To: Eli Zaretskii, emacs-devel

eliz@gnu.org (Eli Zaretskii) writes:

> diff --git a/lisp/help-macro.el b/lisp/help-macro.el
> index 1fa9d82..b3c7e23 100644
> --- a/lisp/help-macro.el
> +++ b/lisp/help-macro.el
> @@ -165,14 +165,18 @@ and then returns."
>                     (let ((cursor-in-echo-area t)
>                           (overriding-local-map local-map))
>                       (setq key (read-key-sequence
> -                                (format "Type one of the options listed%s: "
> +                                (format "Type one of listed options%s: "

Are we sure that this is an improvement?  I find the old text more natural.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 11:30   ` emacs-28 6170c50: Fix regression in help-mode prompt Stefan Kangas
@ 2021-12-14 12:47     ` Colin Baxter 😺
  2021-12-14 13:05       ` Stefan Kangas
  2021-12-14 13:09     ` Eli Zaretskii
  1 sibling, 1 reply; 11+ messages in thread
From: Colin Baxter 😺 @ 2021-12-14 12:47 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Eli Zaretskii, emacs-devel

>>>>> Stefan Kangas <stefankangas@gmail.com> writes:

    > eliz@gnu.org (Eli Zaretskii) writes:
    >> diff --git a/lisp/help-macro.el b/lisp/help-macro.el index
    >> 1fa9d82..b3c7e23 100644 --- a/lisp/help-macro.el +++
    >> b/lisp/help-macro.el @@ -165,14 +165,18 @@ and then returns."
    >> (let ((cursor-in-echo-area t) (overriding-local-map local-map))
    >> (setq key (read-key-sequence - (format "Type one of the options
    >> listed%s: " + (format "Type one of listed options%s: "

    > Are we sure that this is an improvement?  I find the old text more
    > natural.


For me it is an improvement. The help-for-help buffer is taller. My Del
key is the Backspace but that's my detail and will not be universal.

Thanks again.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 12:47     ` Colin Baxter 😺
@ 2021-12-14 13:05       ` Stefan Kangas
  2021-12-14 14:30         ` Colin Baxter 😺
  0 siblings, 1 reply; 11+ messages in thread
From: Stefan Kangas @ 2021-12-14 13:05 UTC (permalink / raw)
  To: Colin Baxter 😺; +Cc: Eli Zaretskii, emacs-devel

Colin Baxter 😺 <m43cap@yandex.com> writes:

> For me it is an improvement. The help-for-help buffer is taller. My Del
> key is the Backspace but that's my detail and will not be universal.

Maybe we are not talking about the same thing.

I was referring to the specific wording in that one quoted line so I
don't see the relevance of talking about keyboard layouts.  IOW, my
question is not technical but about proper use of the English language.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 11:30   ` emacs-28 6170c50: Fix regression in help-mode prompt Stefan Kangas
  2021-12-14 12:47     ` Colin Baxter 😺
@ 2021-12-14 13:09     ` Eli Zaretskii
  2021-12-14 14:01       ` Stephen Berman
  2021-12-14 14:16       ` Stefan Kangas
  1 sibling, 2 replies; 11+ messages in thread
From: Eli Zaretskii @ 2021-12-14 13:09 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 14 Dec 2021 03:30:22 -0800
> 
> eliz@gnu.org (Eli Zaretskii) writes:
> 
> > diff --git a/lisp/help-macro.el b/lisp/help-macro.el
> > index 1fa9d82..b3c7e23 100644
> > --- a/lisp/help-macro.el
> > +++ b/lisp/help-macro.el
> > @@ -165,14 +165,18 @@ and then returns."
> >                     (let ((cursor-in-echo-area t)
> >                           (overriding-local-map local-map))
> >                       (setq key (read-key-sequence
> > -                                (format "Type one of the options listed%s: "
> > +                                (format "Type one of listed options%s: "
> 
> Are we sure that this is an improvement?  I find the old text more natural.

I didn't change the text to improve it, I changed it to make it
shorter.  Because otherwise, when we echo the keys typed by the user,
they overflow the (default) window width, and that resizes the
mini-window, which causes an unpleasant effect of scrolling the Help
window.

If you can suggest a different solution that avoids the resizing,
please do.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 13:09     ` Eli Zaretskii
@ 2021-12-14 14:01       ` Stephen Berman
  2021-12-14 14:28         ` Eli Zaretskii
  2021-12-14 14:16       ` Stefan Kangas
  1 sibling, 1 reply; 11+ messages in thread
From: Stephen Berman @ 2021-12-14 14:01 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Stefan Kangas, emacs-devel

On Tue, 14 Dec 2021 15:09:06 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Tue, 14 Dec 2021 03:30:22 -0800
>>
>> eliz@gnu.org (Eli Zaretskii) writes:
>>
>> > diff --git a/lisp/help-macro.el b/lisp/help-macro.el
>> > index 1fa9d82..b3c7e23 100644
>> > --- a/lisp/help-macro.el
>> > +++ b/lisp/help-macro.el
>> > @@ -165,14 +165,18 @@ and then returns."
>> >                     (let ((cursor-in-echo-area t)
>> >                           (overriding-local-map local-map))
>> >                       (setq key (read-key-sequence
>> > -                                (format "Type one of the options listed%s: "
>> > +                                (format "Type one of listed options%s: "
>>
>> Are we sure that this is an improvement?  I find the old text more natural.
>
> I didn't change the text to improve it, I changed it to make it
> shorter.  Because otherwise, when we echo the keys typed by the user,
> they overflow the (default) window width, and that resizes the
> mini-window, which causes an unpleasant effect of scrolling the Help
> window.
>
> If you can suggest a different solution that avoids the resizing,
> please do.

Is this about the *Metahelp* buffer displayed by typing `C-h ?'?  Then I
think it's sufficient to prompt with "Type one of the options%s: ",
since the buffer containing the options is in plain view.

Steve Berman



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 13:09     ` Eli Zaretskii
  2021-12-14 14:01       ` Stephen Berman
@ 2021-12-14 14:16       ` Stefan Kangas
  2021-12-14 14:30         ` Eli Zaretskii
  1 sibling, 1 reply; 11+ messages in thread
From: Stefan Kangas @ 2021-12-14 14:16 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> If you can suggest a different solution that avoids the resizing,
> please do.

Maybe one of these?

    "Type one of the above keys%s: "
    "Type a key listed above%s: "

Here's the original to make it easier to compare the length:

    "Type one of listed options%s: "



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 14:01       ` Stephen Berman
@ 2021-12-14 14:28         ` Eli Zaretskii
  2021-12-14 14:40           ` Stephen Berman
  0 siblings, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2021-12-14 14:28 UTC (permalink / raw)
  To: Stephen Berman; +Cc: stefankangas, emacs-devel

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Stefan Kangas <stefankangas@gmail.com>,  emacs-devel@gnu.org
> Date: Tue, 14 Dec 2021 15:01:21 +0100
> 
> > I didn't change the text to improve it, I changed it to make it
> > shorter.  Because otherwise, when we echo the keys typed by the user,
> > they overflow the (default) window width, and that resizes the
> > mini-window, which causes an unpleasant effect of scrolling the Help
> > window.
> >
> > If you can suggest a different solution that avoids the resizing,
> > please do.
> 
> Is this about the *Metahelp* buffer displayed by typing `C-h ?'?  Then I
> think it's sufficient to prompt with "Type one of the options%s: ",
> since the buffer containing the options is in plain view.

Those options go out of view as soon as you scroll.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 13:05       ` Stefan Kangas
@ 2021-12-14 14:30         ` Colin Baxter 😺
  0 siblings, 0 replies; 11+ messages in thread
From: Colin Baxter 😺 @ 2021-12-14 14:30 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

>>>>> Stefan Kangas <stefankangas@gmail.com> writes:

    > Colin Baxter 😺 <m43cap@yandex.com> writes:
    >> For me it is an improvement. The help-for-help buffer is
    >> taller. My Del key is the Backspace but that's my detail and will
    >> not be universal.

    > Maybe we are not talking about the same thing.

    > I was referring to the specific wording in that one quoted line so
    > I don't see the relevance of talking about keyboard layouts.  IOW,
    > my question is not technical but about proper use of the English
    > language.

I was only replying tangentially to you.



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 14:16       ` Stefan Kangas
@ 2021-12-14 14:30         ` Eli Zaretskii
  2021-12-14 19:17           ` Stefan Kangas
  0 siblings, 1 reply; 11+ messages in thread
From: Eli Zaretskii @ 2021-12-14 14:30 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 14 Dec 2021 06:16:13 -0800
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > If you can suggest a different solution that avoids the resizing,
> > please do.
> 
> Maybe one of these?
> 
>     "Type one of the above keys%s: "
>     "Type a key listed above%s: "
> 
> Here's the original to make it easier to compare the length:
> 
>     "Type one of listed options%s: "

The shorter one looks better, thanks.

But what if "listed above" are not just keys, but key sequences, or
even something else ("options" is more general)?



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 14:28         ` Eli Zaretskii
@ 2021-12-14 14:40           ` Stephen Berman
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Berman @ 2021-12-14 14:40 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: stefankangas, emacs-devel

On Tue, 14 Dec 2021 16:28:24 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Stephen Berman <stephen.berman@gmx.net>
>> Cc: Stefan Kangas <stefankangas@gmail.com>,  emacs-devel@gnu.org
>> Date: Tue, 14 Dec 2021 15:01:21 +0100
>>
>> > I didn't change the text to improve it, I changed it to make it
>> > shorter.  Because otherwise, when we echo the keys typed by the user,
>> > they overflow the (default) window width, and that resizes the
>> > mini-window, which causes an unpleasant effect of scrolling the Help
>> > window.
>> >
>> > If you can suggest a different solution that avoids the resizing,
>> > please do.
>>
>> Is this about the *Metahelp* buffer displayed by typing `C-h ?'?  Then I
>> think it's sufficient to prompt with "Type one of the options%s: ",
>> since the buffer containing the options is in plain view.
>
> Those options go out of view as soon as you scroll.

I think users know or readily learn that they can scroll back.

Steve Berman



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: emacs-28 6170c50: Fix regression in help-mode prompt
  2021-12-14 14:30         ` Eli Zaretskii
@ 2021-12-14 19:17           ` Stefan Kangas
  0 siblings, 0 replies; 11+ messages in thread
From: Stefan Kangas @ 2021-12-14 19:17 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>>     "Type one of the above keys%s: "
>>     "Type a key listed above%s: "
>
> The shorter one looks better, thanks.
>
> But what if "listed above" are not just keys, but key sequences, or
> even something else ("options" is more general)?

I guess one alternative is

    "Type an option listed above%s: "

which is just one character longer than

    "Type one of listed options%s: "

Stephen Berman <stephen.berman@gmx.net> writes:

> Is this about the *Metahelp* buffer displayed by typing `C-h ?'?  Then I
> think it's sufficient to prompt with "Type one of the options%s: ",
> since the buffer containing the options is in plain view.

That's also good.  I don't really have a strong preference either way,
but yours has the advantage that it is even shorter than the original.



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-12-14 19:17 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20211213135228.14462.36839@vcs0.savannah.gnu.org>
     [not found] ` <20211213135230.17FE620A0A@vcs0.savannah.gnu.org>
2021-12-14 11:30   ` emacs-28 6170c50: Fix regression in help-mode prompt Stefan Kangas
2021-12-14 12:47     ` Colin Baxter 😺
2021-12-14 13:05       ` Stefan Kangas
2021-12-14 14:30         ` Colin Baxter 😺
2021-12-14 13:09     ` Eli Zaretskii
2021-12-14 14:01       ` Stephen Berman
2021-12-14 14:28         ` Eli Zaretskii
2021-12-14 14:40           ` Stephen Berman
2021-12-14 14:16       ` Stefan Kangas
2021-12-14 14:30         ` Eli Zaretskii
2021-12-14 19:17           ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).