From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?I=C3=B1igo?= Serna Newsgroups: gmane.emacs.devel Subject: eshell/addpath broken since commit dea24a0f7d Date: Tue, 25 Jan 2022 19:49:49 +0100 Message-ID: <87tudrwsre.fsf@gmx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 29.0.50 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 25 20:05:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCR8R-000132-6i for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 20:05:43 +0100 Original-Received: from localhost ([::1]:59128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCR8P-0000n1-DD for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 14:05:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCQxp-0005we-Rm for emacs-devel@gnu.org; Tue, 25 Jan 2022 13:54:45 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:33613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCQxn-0004Dl-Fr for emacs-devel@gnu.org; Tue, 25 Jan 2022 13:54:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643136873; bh=ktnG3WcPWHRpDigjaOQ8CalFy+c5W0sjl0Yefz//RKc=; h=X-UI-Sender-Class:From:To:Subject:Date; b=cKtxmx4ag6wnVMD7hmnBe9S++TVNh/Uz3WyLn3tHxaT0FIb1jF037CqWQTELSSnhj Z/ymvv9TbbvnpxpAwIZuSS82oOQ2dAm7UG9haQw48URrgYweKHAWfrT+M4gB1fDwxT 6WFyeelhw9QXjobvH42WCVLMQHowkTR6j3oXAVuU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from zeus.gmx.com ([79.153.222.244]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mw9UE-1mMnmP1q8C-00s90E; Tue, 25 Jan 2022 19:54:33 +0100 X-Provags-ID: V03:K1:OKCMQ7f25DRW9c+Hl+cPTSEUhbIMtVkhXkO59EmicIOuz6orWEd UM/2W1l2CNWlKvV5oOo7swTajQ8u/Q+HdeHh2MtQJGhnfhUCutvaC1r/83xoI5dcoO7MCXN uJl2vJQ2a/tMnE5oPZaKFaEWZBeTHiGvi4ujdMtxitqgofQQxacuhzbkSu/bGXD2bMdDgX4 kpH/dC201ZiosRTIqX2Rw== X-UI-Out-Filterresults: notjunk:1;V03:K0:4+BI0B6kCmI=:lMb0fsf6rGEYg07gx6zR80 9Atkiie8mPam9lWmxSNIdS5n1CjCi5fSiXymcDlOmoFEaM5H5IzidfxgRAvM76ScezLbngmBM chn1SUqUI8vBDHkPX0VL5AcPl0mBmwxS8ySceQRQTDOjG680+OaZqGD3TNnPbmO7KOReex69Q MPwf/+hlTK+zEkMnk1CjRpVuYMeJr8SwL3a4q+oR6y5GkJGggr0hynjxf7fhvTDJ5i/Hn8Yj2 ciOqIK66sY1oKd0d8fN91ueoWBfT4dyB07h5OKosmlxY2FQCW91m0AR0gl5Utg97CzzZfG2bj do5Ll/xk07ggcZ8+k9njqEBoUmXAPLaxnA8OyHlenZejd1q1gcJf8UOeMJOgCQQhugthHaXgg 25dPqW9+iQSBj5PIdBgWc4Hux+IMkhejl6Vr4Emosa9/FLhRdhD4dqyJcaGH2kKBKQZzLasmX wnwV/5CKr1stJOi5EJcKo+Uk7yOyDLl5yNkyMFVqdoW59SgpdtETUtPcjlrJ3O48Brybrx4k7 OcH7PYOmyd8fR1pdbrpFaBVyYBsrJUH6cKoAzSs5mm5q4znbKpCTFisZVsBSgCAa+wm2tT5O8 J05oBSSIDIAljDjHNbmFWX55CtAriDCf1QZgpVlNj3gbdmqlL2F6229euhBdB378/sVnFay7d B2taOwNSGMlmrcuUjoe3w9N8rdq7x/LgytWu4snLFqfgVUrdaogQFoyPr4KmXxb/ft9qtHBfR RgzbxwcdVrTsuig7Aw4mlZotaN8/JvYwienf8BX9LBBVWv4Km1uS2hDqtZAYlWHpn8Gh/BX1 Received-SPF: pass client-ip=212.227.15.18; envelope-from=inigoserna@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285378 Archived-At: Hi It looks `eshell/addpath' is broken in master since commit=20 dea24a0f7d [1]. $ src/emacs --debug-init -Q --eval "(progn (require 'eshell)=20 (eshell/addpath \"~/bin\"))" Debugger entered--Lisp error: (wrong-number-of-arguments (4 . 4)=20 3) eshell--do-opts("addpath" ((98 "begin" nil prepend "add path=20 element at beginning") (104 "help" nil nil "display this usage=20 message") :usage "[-b] PATH\nAdds the given PATH to $PATH.")=20 ("~/bin")) eshell/addpath("~/bin") Thanks, --=20 I=C3=B1igo Serna [1] commit dea24a0f7d4ae42fae912dd724a770678054989a Author: Jim Porter Date: Mon Jan 24 21:03:42 2022 -0800 Don't manipulate args in-place for 'eshell-eval-using-options' =20=20=20=20 This is necessary for preserve the original arguments to=20 forward on to :external commands. Previously, when :preserve-args was also=20 set, the original argument list could be altered, changing the meaning=20 of the command.