From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Thu, 03 Mar 2022 21:13:04 -0600 Message-ID: <87tucewgu7.fsf@red-bean.com> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 04:13:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPyO2-0002V6-64 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 04:13:46 +0100 Original-Received: from localhost ([::1]:49466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPyO1-0000pu-9I for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Mar 2022 22:13:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPyNS-0008NM-Kz for emacs-devel@gnu.org; Thu, 03 Mar 2022 22:13:10 -0500 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:54240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPyNQ-00021U-HW; Thu, 03 Mar 2022 22:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:References:Subject:Cc:To:From:Sender:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=DUPGopVQKZ8N7eJrP0xKoqMDDe42XH8T7jdZfftXI6s=; t=1646363587; x=1647573187; b=Qsy2Ce3VSpOQRLGEHEDUjNC0FFze59oGXZZC2TiZt+k0dA+Hf0JaIfyL0MqbQieS9q6jgYPek8P YE9PfS+qogsCPb0Ts+StLX8hfIy36N/IMk9YPlqGC/j1q0WW3y54cwVupOtSnaoJXVugDOri71gov j5Llkg99mNfg3v5bwNRd18dVJjdzYO8o/NTwBiZJk6rbJB14/6bCmF1ln32Zx39u1UHQYj8Zb1rzW QA82E6jDDAGdYM+H/SxCoS/KNOZoTPZd8AxrUWOluoL4FuWx18oxsbVNMPcrEPjJlz56rI2ApGwXf kajOHFqX+QtMydscTxMMB9U+2n4+FTEAOd5Q==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:60042 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nPyNN-00CTYs-12; Fri, 04 Mar 2022 03:13:06 +0000 Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286798 Archived-At: On 03 Mar 2022, Eli Zaretskii wrote: >> From: Karl Fogel Date: Thu, 03 Mar 2022 >> 11:41:55 -0600 Cc: emacs-devel On 03 Mar >> 2022, Manuel Giraud wrote: >> >Here is a patch that I think fix the default >> >`bookmark-bmenu-list' sorting when `bookmark-sort-flag' is >> >nil. >> This looks correct to me. Thank you for the fix. I'm testing >> it now on 'emacs-28' and 'master' (it should behave the same >> on both, of course, but might as well make sure). Assuming it >> behaves as expected, I'll apply using 'git patch' on the >> emacs-28 branch. > Please don't install new features on the release branch. This is a bugfix, not a new feature. I re-read the "Branches" section in CONTRIBUTE before I posted -- the relevant part is this, I think: > If you are fixing a bug that exists in the current release, > you > should generally commit it to the release branch; it will be > merged > to the master branch later by the gitmerge function. However, > when > the release branch is for Emacs version NN.2 and later, or > when it > is for Emacs version NN.1 that is in the very last stages of > its > pretest, that branch is considered to be in a feature freeze: > only > bug fixes that are "safe" or are fixing major problems should > go to > the release branch, the rest should be committed to the master > branch. This is so to avoid destabilizing the next Emacs > release. > If you are unsure whether your bug fix is "safe" enough for > the > release branch, ask on the emacs-devel mailing list. That indicates that 'emacs-28' is the right branch for this change. That branch is on version 28.0.91 right now, not 28.2 nor late 28.1. I'm happy to put this change on whatever branch you prefer, of course. However, independent of this specific case, in general how should one determine what branch to put something on, if the guidance in CONTRIBUTE isn't enough? (Or am I misreading that guidance? It seems pretty straightforward...) This change easily fits the description "safe", by the way. (In the course of testing it, I've discovered another interesting corner-case buglet, but I'll commit this first and then deal with the buglet separately. That second fix is likely to be safe too.) Best regards, -Karl