From: Karl Fogel <kfogel@red-bean.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting.
Date: Thu, 03 Mar 2022 21:13:04 -0600 [thread overview]
Message-ID: <87tucewgu7.fsf@red-bean.com> (raw)
In-Reply-To: 83v8wuj3v0.fsf@gnu.org
On 03 Mar 2022, Eli Zaretskii wrote:
>> From: Karl Fogel <kfogel@red-bean.com> Date: Thu, 03 Mar 2022
>> 11:41:55 -0600 Cc: emacs-devel <emacs-devel@gnu.org> On 03 Mar
>> 2022, Manuel Giraud wrote:
>> >Here is a patch that I think fix the default
>> >`bookmark-bmenu-list' sorting when `bookmark-sort-flag' is
>> >nil.
>> This looks correct to me. Thank you for the fix. I'm testing
>> it now on 'emacs-28' and 'master' (it should behave the same
>> on both, of course, but might as well make sure). Assuming it
>> behaves as expected, I'll apply using 'git patch' on the
>> emacs-28 branch.
> Please don't install new features on the release branch.
This is a bugfix, not a new feature. I re-read the "Branches"
section in CONTRIBUTE before I posted -- the relevant part is
this, I think:
> If you are fixing a bug that exists in the current release,
> you
> should generally commit it to the release branch; it will be
> merged
> to the master branch later by the gitmerge function. However,
> when
> the release branch is for Emacs version NN.2 and later, or
> when it
> is for Emacs version NN.1 that is in the very last stages of
> its
> pretest, that branch is considered to be in a feature freeze:
> only
> bug fixes that are "safe" or are fixing major problems should
> go to
> the release branch, the rest should be committed to the master
> branch. This is so to avoid destabilizing the next Emacs
> release.
> If you are unsure whether your bug fix is "safe" enough for
> the
> release branch, ask on the emacs-devel mailing list.
That indicates that 'emacs-28' is the right branch for this
change. That branch is on version 28.0.91 right now, not 28.2 nor
late 28.1.
I'm happy to put this change on whatever branch you prefer, of
course. However, independent of this specific case, in general
how should one determine what branch to put something on, if the
guidance in CONTRIBUTE isn't enough? (Or am I misreading that
guidance? It seems pretty straightforward...) This change
easily fits the description "safe", by the way.
(In the course of testing it, I've discovered another interesting
corner-case buglet, but I'll commit this first and then deal with
the buglet separately. That second fix is likely to be safe too.)
Best regards, -Karl
next prev parent reply other threads:[~2022-03-04 3:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:39 [PATCH] Fix bookmark-bmenu-list sorting Manuel Giraud
2022-03-03 17:41 ` Karl Fogel
2022-03-03 18:19 ` Eli Zaretskii
2022-03-04 3:13 ` Karl Fogel [this message]
2022-03-04 7:14 ` Eli Zaretskii
2022-03-04 8:18 ` Karl Fogel
2022-03-04 11:46 ` Eli Zaretskii
2022-03-04 13:25 ` Manuel Giraud
2022-03-04 13:33 ` Eli Zaretskii
2022-03-04 15:15 ` Manuel Giraud
2022-03-04 15:26 ` Eli Zaretskii
2022-03-04 17:41 ` Manuel Giraud
2022-03-04 19:37 ` Eli Zaretskii
2022-03-07 3:32 ` Karl Fogel
2022-03-07 9:21 ` Manuel Giraud
2022-03-20 23:40 ` Karl Fogel
2022-03-21 7:54 ` Manuel Giraud
2022-03-21 14:14 ` Karl Fogel
2022-04-20 18:09 ` [PATCH] Improve sorting in the bookmark list buffer Karl Fogel
2022-04-20 19:02 ` Eli Zaretskii
2022-04-20 19:49 ` Karl Fogel
2022-04-24 17:30 ` Karl Fogel
2022-04-24 18:13 ` Eli Zaretskii
2022-04-24 19:10 ` Karl Fogel
2022-04-25 9:35 ` Manuel Giraud
2022-04-25 17:50 ` Karl Fogel
2022-04-26 7:51 ` Manuel Giraud
2022-03-07 13:12 ` [PATCH] Fix bookmark-bmenu-list sorting Eli Zaretskii
2022-03-07 19:03 ` Karl Fogel
2022-03-07 5:17 ` Karl Fogel
2022-03-04 8:34 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tucewgu7.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).