unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Filipp Gunbin <fgunbin@fastmail.fm>,
	winkler@gnu.org, emacs-devel@gnu.org
Subject: Re: process-file instead of call-process in proced.el?
Date: Fri, 25 Mar 2022 12:46:06 +0100	[thread overview]
Message-ID: <87tubmi7b5.fsf@gmx.de> (raw)
In-Reply-To: <83v8w2b9wn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Mar 2022 13:31:52 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> The patch only changes call-process to process-file, to support file
>> handlers.  Setting "kill" into proced-signal-function is a user
>> customization.
>
> Sorry, from my POV fixing something means making it work as correctly
> as we can reasonably do.  If it didn't work correctly before, we
> should fix that as well, as part of any work on the relevant code.  I
> understand that, if the doing TRT is complicated, it could be left to
> a separate patch, but in this case it isn't complicated at all.
>
> So let's fix this part of proced to work on all supported platforms,
> okay?

I don't understand why an external "kill" process is applied. Couldn't
we simply call always `signal-process'? A comment in
`proced-send-signal' recommends this already.

Then we could give `signal-process' a handler, like `interrupt-process'
has already. (Well, we would need a mean to indicate, that a process-id
is meant for a remote host.)

Best regards, Michael.



  reply	other threads:[~2022-03-25 11:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25  0:09 process-file instead of call-process in proced.el? Filipp Gunbin
2022-03-25  6:54 ` Eli Zaretskii
2022-03-25 10:24   ` Filipp Gunbin
2022-03-25 10:31     ` Eli Zaretskii
2022-03-25 11:46       ` Michael Albinus [this message]
2022-03-25 12:12         ` Eli Zaretskii
2022-03-25 12:29           ` Filipp Gunbin
2022-03-25 13:34             ` Roland Winkler
2022-03-25 13:58             ` Michael Albinus
2022-03-25 14:26               ` Filipp Gunbin
2022-03-25 14:29                 ` Michael Albinus
2022-03-25 15:40                   ` Filipp Gunbin
2022-03-25 15:43                     ` Michael Albinus
2022-03-26 16:49 ` Michael Albinus
2022-03-26 17:37   ` Roland Winkler
2022-03-26 18:31     ` Michael Albinus
2022-03-26 18:49       ` Roland Winkler
2022-03-27  7:28         ` Michael Albinus
2022-03-27 14:08           ` Michael Albinus
2022-03-28  2:57             ` Roland Winkler
2022-03-28  7:41               ` Michael Albinus
2022-03-28 14:34                 ` Roland Winkler
2022-03-28 14:53             ` Filipp Gunbin
2022-03-28 15:40               ` Michael Albinus
2022-03-28 16:11                 ` Filipp Gunbin
2022-03-28 16:39                   ` Michael Albinus
2022-03-28 19:42                     ` Filipp Gunbin
2022-03-30 11:20                       ` Michael Albinus
2022-03-30 15:34                         ` Filipp Gunbin
2022-03-28 17:08             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tubmi7b5.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=fgunbin@fastmail.fm \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).