From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James N. V. Cash Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Fri, 29 Apr 2022 13:20:07 -0400 Message-ID: <87tuab3iyg.fsf@occasionallycogent.com> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87zgk42day.fsf@occasionallycogent.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38503"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 19:21:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkUJN-0009Zl-Vz for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 19:21:45 +0200 Original-Received: from localhost ([::1]:49096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkUJM-0002hH-SL for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 13:21:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkUHs-0001Oj-0a for emacs-devel@gnu.org; Fri, 29 Apr 2022 13:20:12 -0400 Original-Received: from mail-qt1-f180.google.com ([209.85.160.180]:33396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkUHq-0007uo-I1 for emacs-devel@gnu.org; Fri, 29 Apr 2022 13:20:11 -0400 Original-Received: by mail-qt1-f180.google.com with SMTP id hf18so6282432qtb.0 for ; Fri, 29 Apr 2022 10:20:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=L5Oo5KViHntla0aPfy9LwPzOBIWGa6z0oX2VmdK43b0=; b=5yUpGr0oPLlP5j0/F9DcA+AtoORTZkmCoWX5xM6yENFS7QHn87pZwF6kxfZfKkWvs+ V7FrQ6XIdSZeyme/ZVRP73aL4zvcQTvopmcspWcwKLI+QRblj8gTgNMZHN/1z44uCmWy p702jNYthg+g7aZrrwr4sCiF1g7Nx1zj2BDzD/psHK003GIKmL/bYAER7NR5FBQhvPc0 QUfKGgnooOmPc82uh/OnaGTVAb0GU/Qlil8EO91weG7LyUoVWRMjlaJKLtox1XvQsABI qgNzaKzLYJ8vBQFpz0p0tCJruHsdu3LdsDnM96SCDx4wuC6wPHNlzyEs604b8hMkhI8E X1ig== X-Gm-Message-State: AOAM533ivARVNDFdqxscyC/9j8FrD2LlBiPr9mxxy4wEdx2Ci4cJXPpt OLPzWZrbFM3zeKpjp80kBK8XTUs/Mio= X-Google-Smtp-Source: ABdhPJwz3kqJPFNSTTAGWybu2AqTOsBrjxe6MwKSv9ukMixTQpPMKPSuyTGi7HqdwJpKE1j4bBNTwg== X-Received: by 2002:ac8:7d4e:0:b0:2e1:ba47:d757 with SMTP id h14-20020ac87d4e000000b002e1ba47d757mr421090qtb.248.1651252809453; Fri, 29 Apr 2022 10:20:09 -0700 (PDT) Original-Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id 21-20020a370915000000b0069f93242808sm1715836qkj.62.2022.04.29.10.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 10:20:09 -0700 (PDT) Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 8903F27C0054; Fri, 29 Apr 2022 13:20:08 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 29 Apr 2022 13:20:08 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpeflrghmvghs ucfprdcuggdrucevrghshhcuoehjrghmvghsrdhnvhgtsehgmhgrihhlrdgtohhmqeenuc ggtffrrghtthgvrhhnpeduhedtueekkeeivdefkedufeekieeljeegheffhfeiveeuhfek uefffefgieelkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehjrghmvghspggtrghshhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihht hidquddvfedvtddvjeelvddqvdejkeegtdduhedvqdhjrghmvghsrdhnvhgtpeepghhmrg hilhdrtghomhesohgttggrshhiohhnrghllhihtghoghgvnhhtrdgtohhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Apr 2022 13:20:07 -0400 (EDT) In-Reply-To: Received-SPF: pass client-ip=209.85.160.180; envelope-from=james.nvc@gmail.com; helo=mail-qt1-f180.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289013 Archived-At: Stefan Monnier writes: > James N. V. Cash [2022-04-29 10:07:33] wrote: >> Stefan Monnier writes: >>>> + (let ((beg (if (number-or-marker-p beg) >>>> + beg >>>> + (save-excursion >>>> + (goto-char (minibuffer-prompt-end)) >>>> + (search-forward beg)))) >>>> + (end (if (number-or-marker-p end) >>>> + end >>>> + (save-excursion >>>> + (goto-char (point-max)) >>>> + (search-backward end))))) >>> >>> What if there are several matches for `beg` and/or for `end` in >>> the buffer? How do we know we got the intended one? >> >> A good question; as far as I can tell though, `beg` and `end` are only >> strings when called via `choose-completion` in `simple.el`, when it >> passes in `base-affixes`. `base-affixes` is in turn set to >> `completion-base-affixes`, which gets set in >> `minibuffer-completion-help`. There, the value that becomes `beg` is >> `(buffer-substring (minibuffer--completion-prompt-end) (+ start base-size))` >> and `end` is `(buffer-substring (point) (point-max))`, so I think that changing >> `minibuffer-prompt-end` in my patch to >> `minibuffer--completion-prompt-end` would suffice to ensure that it is >> always matching from the correct point to match the intended positions. > > I think rather than (minibuffer--completion-prompt-end) and (point-max), > we should be using "the beginning of the completion area" and "the end > of the completion area". In a typical minibuffer completion, that's > exactly the same, but in `completing-read-multiple` or > `complete-in-region` the difference can be significant. In the `completing-read-multiple` case, the `beg` is going to be the previous completions, so I think this is exactly finding the completion area (it also seems that `minibuffer--completion-prompt-end` is the same value as `minibuffer-prompt-end,` it just also raises an error). In my brief experimentation, it appears `complete-in-region` receives `beg` and `end` as numbers, so it doesn't go through this searching stuff at all. James