* Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration
[not found] ` <20220819110614.BB982C04F0E@vcs2.savannah.gnu.org>
@ 2022-08-19 11:58 ` Po Lu
2022-08-19 12:02 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-08-19 11:58 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
Lars Ingebrigtsen <larsi@gnus.org> writes:
> branch: master
> commit 088171e05316c9188186a731f3c7e68c103c4e0a
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Fix ns-win.el (x-file-dialog) declaration
>
> * lisp/term/ns-win.el (x-file-dialog): Give the function the same
> signature here as other definitions.
> ---
> lisp/term/ns-win.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
> index e26191b33b..56aca2bd83 100644
> --- a/lisp/term/ns-win.el
> +++ b/lisp/term/ns-win.el
> @@ -439,7 +439,8 @@ Lines are highlighted according to `ns-input-line'."
>
> ;;;; File handling.
>
> -(defun x-file-dialog (prompt dir default_filename mustmatch only_dir_p)
> +(defun x-file-dialog (prompt dir &optional default_filename
> + mustmatch only_dir_p)
> "SKIP: real doc in xfns.c."
> (ns-read-file-name prompt dir mustmatch default_filename only_dir_p))
>
I guess it would be good to change the function arguments names too to
avoid the underscores.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-19 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166090717426.4526.7562850425788954733@vcs2.savannah.gnu.org>
[not found] ` <20220819110614.BB982C04F0E@vcs2.savannah.gnu.org>
2022-08-19 11:58 ` master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration Po Lu
2022-08-19 12:02 ` Lars Ingebrigtsen
2022-08-19 13:29 ` Po Lu
2022-08-19 13:37 ` Lars Ingebrigtsen
2022-08-19 14:05 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).