From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: master 48aacbf292 2/2: Make many seldom-used generalized variables obsolete Date: Sat, 10 Sep 2022 13:17:48 +0800 Message-ID: <87tu5fzu2r.fsf@localhost> References: <166111278304.2846.13033924580993120733@vcs2.savannah.gnu.org> <20220821201303.AD1E6C0088A@vcs2.savannah.gnu.org> <877d2w1ua0.fsf@tcd.ie> <87pmgojy0m.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 10 07:20:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWsvJ-0007lI-OH for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Sep 2022 07:20:57 +0200 Original-Received: from localhost ([::1]:42782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWsvI-0000LC-PC for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Sep 2022 01:20:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWsrR-0006VR-D2 for emacs-devel@gnu.org; Sat, 10 Sep 2022 01:16:57 -0400 Original-Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:46625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWsrP-0003SK-Op for emacs-devel@gnu.org; Sat, 10 Sep 2022 01:16:57 -0400 Original-Received: by mail-pg1-x52d.google.com with SMTP id 78so3373328pgb.13 for ; Fri, 09 Sep 2022 22:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=EnRUCo42nxq4sutGLKZuiu7HX0O0mfJKf+7VritWLZo=; b=WVnY2Iie8nYAbQ+Ps7tVWQrY5K5uCUF3OVAIdKRJNvjzBrAHqkFOpY5vaKxv0/FU3R /703eHZ22SaH8mkXsKsVk27B39rh1pE6L05jUrIiVdgxipKn94t47j7J+G+t8ZdPW+6b cjy1s74DAEykiyduUoyvqf9LU403E0YToW+7TklDzC4++K06Co+KqkHNuyyYRsXNBwGI jJMsTIt4AojBEnLStN9tyCwjqouAloJNDz6tUxYm9TiwNaiVa6IAVF7UY5FWnYAYo02C YMIZDYOFGPr7n0x9UOEVSq9wYLCO7Aoq0EOyklysde0VCqHBRLh8Lgd3M5BkHh/wxrnp mSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=EnRUCo42nxq4sutGLKZuiu7HX0O0mfJKf+7VritWLZo=; b=hTrjth8hWTleed25xB9Bg3fRn0BOLJVxk6m39DPXIGrDh/66yHSePvsHXBSV3HQEBc PMrSUbs4f7tZjrwPjmc7AuLcnsWuRertN/0Vj30MeLDWcsHC/NnDYIj8w/QnO8XRGvLi ynHPTAHGiW6aa41TLYorH5VhHhBdfb8J/zdGNQkqOPlSlcZC9rs3fCvIYcJjFJmeMBPo iXNJ1Ibq+I0+vXLYHFcTRgzp0bGFYkQGiajokOU7md4+prkKIfsnHaKtDjnI2CjINaw8 dsnJ+ywVczswswtgzaV9v4YfT/v3U9am/sdErd+qtffTmPM4CNAS5HdGF+gptiLjIYjg gPQA== X-Gm-Message-State: ACgBeo1MRd19Fy9o99cv5veRZZ6KGB435j0LOv8aQhZaY3yZuf8i5UdW /zqrp1R7rfhTMv2sIrevtNA= X-Google-Smtp-Source: AA6agR6RUdYzogs0Y/tk+DTtck8lOXK0l6E1hqqIb+7tPlvYsX43YRNHDAgyA2mF589y0/tZ/sqsIw== X-Received: by 2002:a63:3:0:b0:42e:16f4:145f with SMTP id 3-20020a630003000000b0042e16f4145fmr15034879pga.141.1662787014409; Fri, 09 Sep 2022 22:16:54 -0700 (PDT) Original-Received: from localhost ([1.83.154.15]) by smtp.gmail.com with ESMTPSA id d8-20020a170902654800b0016d295888e3sm1314819pln.241.2022.09.09.22.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 22:16:53 -0700 (PDT) In-Reply-To: <87pmgojy0m.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295098 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> If frame-height is obsolete, frame-width should be as well, right? > > Yup. Now done. This commit also obsoleted a number of generalized variables used by Org. In particular, `buffer-substring', and `buffer-string'. While it is indeed possible to set buffer contents without the above variables, it cannot (AFAIK) be done using a single function call. Would it be possible to provide a function replacement for setting a buffer text in the whole buffer/buffer region? Also, obsoleting `buffer-file-name' revealed one potentially concerning fact about generalized variables. The expansion of `buffer-file-name' setter, `set-visited-file-name' "... also renames the buffer to correspond to the new file." I am now wondering if there are any non-obvious side effects when using other generalized variables - there is (AFAIK) no documentation about what exactly various setters for generalized variables do other than occasional paragraph in the manual. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92