From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: "Emacs-devel@gnu.org" <Emacs-devel@gnu.org>
Subject: Re: "Eager macro-expansion failure: (excessive-variable-binding)"
Date: Wed, 14 Sep 2022 17:38:00 +0200 [thread overview]
Message-ID: <87tu5a55lz.fsf@gnus.org> (raw)
In-Reply-To: <87czby6l8q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Sep 2022 17:15:01 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Hm... yes, it seems like this (or something else recently) increased
> the "make -j32" build time from 1:08m to 1:17m, which is pretty
> significant. I'm doing further rebuilds to see if that's indeed the
> culprit.
Yes, but via ldefs-boot.el which was done a bit later.
The following patch brings build times back down to 1:08s.
diff --git a/lisp/ldefs-boot.el b/lisp/ldefs-boot.el
index 909ecf773c..fd2c68b98d 100644
--- a/lisp/ldefs-boot.el
+++ b/lisp/ldefs-boot.el
@@ -33564,7 +33564,7 @@ "vc-filewise"
this list might be extended in the future.
(fn SWITCHES)")
-(put 'vc-git-annotate-switches 'safe-local-variable #'vc-git-annotate-switches-safe-p)
+(put 'vc-git-annotate-switches 'safe-local-variable (lambda (switches) (equal switches "-w")))
(defun vc-git-registered (file)
"Return non-nil if FILE is registered with git."
(if (vc-find-root file ".git") ; Short cut.
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 8d8ea33f8b..0764282676 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -135,7 +135,7 @@ vc-git-annotate-switches
(string :tag "Argument String")
(repeat :tag "Argument List" :value ("") string))
:version "25.1")
-;;;###autoload(put 'vc-git-annotate-switches 'safe-local-variable #'vc-git-annotate-switches-safe-p)
+;;;###autoload(put 'vc-git-annotate-switches 'safe-local-variable (lambda (switches) (equal switches "-w")))
(defcustom vc-git-log-switches nil
"String or list of strings specifying switches for Git log under VC."
next prev parent reply other threads:[~2022-09-14 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 12:18 "Eager macro-expansion failure: (excessive-variable-binding)" Lars Ingebrigtsen
2022-09-14 14:16 ` Mattias Engdegård
2022-09-14 15:15 ` Lars Ingebrigtsen
2022-09-14 15:38 ` Lars Ingebrigtsen [this message]
2022-09-14 16:50 ` Eli Zaretskii
2022-09-14 16:52 ` Lars Ingebrigtsen
2022-09-14 16:55 ` Eli Zaretskii
2022-09-14 17:03 ` Lars Ingebrigtsen
2022-09-14 17:09 ` Eli Zaretskii
2022-09-14 17:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5a55lz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=Emacs-devel@gnu.org \
--cc=mattias.engdegard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).