From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: TypeScript support for tree-sitter (was Re: Call for volunteers: add tree-sitter support to major modes) Date: Tue, 11 Oct 2022 15:48:27 +0200 Message-ID: <87tu4albdg.fsf@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <87h70b8zqs.fsf@thornhill.no> <835ygrhd1p.fsf@gnu.org> <87bkqj8w8n.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18309"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , casouri@gmail.com, Matus Goljer , jostein@kjonigsen.net To: Stefan Monnier , "Theodor Thornhill via Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 15:53:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiFhK-0004T9-Hi for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:53:30 +0200 Original-Received: from localhost ([::1]:53092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiFhJ-00036C-C1 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:53:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiFcb-0008Sc-Mm for emacs-devel@gnu.org; Tue, 11 Oct 2022 09:48:37 -0400 Original-Received: from out0.migadu.com ([2001:41d0:2:267::]:12547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiFcY-0001yu-Oa; Tue, 11 Oct 2022 09:48:37 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665496110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IV9A2fVVR9JIJeWY8dYwrDC6ysSboKtwNQN+9WcZs6Y=; b=o8XYmXMGNZ24eHIr3gldlBRRiw6txnd9ZIGi3JNUqCyQBA+8wIxkuAvjh2a/bW37EoIF9w YxHsswuG+vKHaiQMBOKaF9OjXui+TX/TKU+4ncsR23ztt93WXYP3ny9XYlB6vjk29ZJdox pH0syVbbppAShBqDbD4O950x90gO42PQvg9/TAtrD4fPTDWW+rhUXkz4lzKvLP0OHxbvJV dT2H4Ff03cuaKxLgmbc1vz5psKbQZYyhI+2kvZzn4KX3sB5e9i6sTQtBCT7EBcY5nmpBAf ANpvPSICUUAdcPmZFA7nxNrMlkYb+GVtjKShIkLqjYSRxr/29CQTcluhc9brPQ== In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297485 Archived-At: Stefan Monnier writes: >> See attached patch. I believe this should adhere to Yuan Fu's >> standards aswell. > > The function name `typescript-mode` is already taken by NonGNU ELPA's > `typescript-mode` package. > > Please coordinate with that package's author to avoid imposing on the > user the need to resolve that conflict. > > The ideal way is to merge the two so there's only one. > [ And the second best is to kill one of the two, so there's only one. ] > > If the administrative hurdles make it impossible (i.e. we can't bring > `typescript-mode` into Emacs core and we're not willing to forgo having > that tree-sitter support in core), maybe the next best would be > something like: use another name for Emacs's built-in mode then adjust > `typescript-mode.el` to derive from `ts-mode` with enough backward > compatibility filling to make it not too painful for the end users. > > For the sake of end-users I strongly recommend we try and merge the two. > Please, please, pretty please, > Me and Jostein, two of the maintainers of this mode are pretty decided on not being able to support the old variant for much longer. We will deprecate it and move on from it as quick as possible. We need to make some arrangements not to conflict, but we should deprecate the nongnu elpa variant asap. So - the external one will be killed, and this new one will live on. There are too many issues not possible to solve feasibly and satisfactory. What do you think? Theo