Re: [NonGNU ELPA] 11 new packages!

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

Akib Azmain Turja <akib@disroot.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>>> OK, then adding them to NonGNU ELPA seems like the safer bet.
>>>>
>>>> I'd like to add them, but I'll have to take the time to review them
>>>> first, which might take a bit.
>>>
>>> What do you want to review?  The patches, or the packages?
>>
>> The packages, unless you aren't interested in comments.
>
> Review if you wish, I welcome feedback.

Sorry for the delay, here are a few more comments:

iwindow:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: comments.diff --]
[-- Type: text/x-diff, Size: 2747 bytes --]

diff --git a/iwindow.el b/iwindow.el
index c808bd26f9..eab2c3084b 100644
--- a/iwindow.el
+++ b/iwindow.el
@@ -46,6 +46,8 @@
 ;;; Code:
 
 (require 'cl-lib)
+;; By adding `seq' as a dependency you could lower the dependency on
+;; the minimum version of Emacs.
 
 (defgroup iwindow nil
   "Interactively manipulate windows."
@@ -54,7 +56,7 @@
   :prefix "iwindow-")
 
 (defcustom iwindow-selection-keys
-  '(?0 ?1 ?2 ?3 ?4 ?5 ?6 ?7 ?8 ?9)
+  (number-sequence ?0 ?9)
   "List of keys to use to select window.
 
 Each element should be a key that `read-key' can return."
@@ -141,8 +143,7 @@ list of form (OPTION...), whose length of no more than the length of
       (walk tree nil))
     (run-hook-wrapped 'iwindow-decoration-functions
                       (lambda (fn) (ignore (push fn decorators))))
-    (cl-labels ((call-decorators
-                  (fns)
+    (cl-labels ((call-decorators (fns)
                   (with-selected-window current-window
                     (if fns
                         (funcall (car fns) windows
@@ -157,6 +158,7 @@ list of form (OPTION...), whose length of no more than the length of
 Return the window chosen."
   (if (windowp tree)
       (prog1
+          ;; Is there really a point to using `prog1' here?
           tree
         (redraw-display))
     (let ((option nil)
@@ -192,7 +194,7 @@ WINDOW and ignore WINDOW when PREDICATE returns nil."
                          (seq-filter predicate windows)
                        windows)))
     (when candidates
-      (if (cdr candidates)                 ; (> (length candidates) 1)
+      (if (cdr candidates)                 ;(length> candidates 1)
           (iwindow--ask (iwindow--make-decision-tree
                          (vconcat windows) 0 (length windows)
                          predicate))
@@ -215,7 +217,7 @@ WINDOWS and CALLBACK is described in the docstring of
                                        (alist-get (selected-window)
                                                   ',windows)))
                                  (mapconcat
-                                  (apply-partially #'string ? )
+                                  (apply-partially #'string ?\s)
                                   keys "")
                                ',(alist-get (current-buffer)
                                             original-mode-lines)))))
@@ -261,6 +263,7 @@ WINDOWS and CALLBACK is described in the docstring of
 
 WINDOWS and CALLBACK is described in the docstring of
 `iwindow-decoration-functions', which see."
+  ;; Again, recommending Compat you could make use of `named-let' here
   (cl-labels ((setup-windows (window-list)
                 (with-selected-window (caar window-list)
                   (let ((ov nil))

[-- Attachment #3: Type: text/plain, Size: 8 bytes --]


blow:


[-- Attachment #4: blow.el --]
[-- Type: application/emacs-lisp, Size: 8348 bytes --]