Re: org-mode 9.6 and Emacs Built from Git HEAD

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> How exactly would I debug this? Started happening after switching to
> the recently released org-mode 9.6

Do you fiddle with char-property-alias-alist? That's what Org now uses
for hiding links.

A more general suggestion is bisecting.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

Trying to and failing to debug an org issue with/without my settings:

1. With  emacs -q and emacspeak loaded, links in org-buffers show up
   correctly when using "descriptive" ie org-link-descriptive set to
   T, the URL portion of org links is correctly hidden.

2. But when I do the same with my customizations from custom loaed,
   the links show up in their raw form.

How exactly would I debug this? Started happening after switching to
the recently released org-mode 9.6


-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Eli Zaretskii]

> Date: Wed, 30 Nov 2022 19:46:05 -0800
> From: "T.V Raman" <raman@google.com>
> 
> Trying to and failing to debug an org issue with/without my settings:
> 
> 1. With  emacs -q and emacspeak loaded, links in org-buffers show up
>    correctly when using "descriptive" ie org-link-descriptive set to
>    T, the URL portion of org links is correctly hidden.
> 
> 2. But when I do the same with my customizations from custom loaed,
>    the links show up in their raw form.
> 
> How exactly would I debug this? Started happening after switching to
> the recently released org-mode 9.6

I suggest to ask this on the Org list first.

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> For org-mode folks: could you point me at what to implement  to get the
> text-property version  at my end; typically means I need to understand
> what makes things invisible and have that make things inaudible.

See `org-fold-core-region'.

The basic idea: we make use of 'invisible text property.
The value of 'invisible text property is actually set via other
properties that are linked to 'invisible via
`char-property-alias-alist'.
Links in particular are making use of a combination of two 'invisible
values: one set to be hidden via `buffer-invisibility-spec' and the other
is set to be displayed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

Not directly -- just did a quick check.
Still mysterious since emacs -q with emacspeak doesn't exhibit the
problem.

I went back to emacs 29 and still see the problem, so it's somewhere
in org.

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

--

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 786 bytes --]

"T.V Raman" <raman@google.com> writes:
I found  the cause and the temporary fix for emacspeak is to set 
'(org-fold-core-style 'overlays)

For org-mode folks: could you point me at what to implement  to get the
text-property version  at my end; typically means I need to understand
what makes things invisible and have that make things inaudible.


> Not directly -- just did a quick check.
> Still mysterious since emacs -q with emacspeak doesn't exhibit the
> problem.
>
> I went back to emacs 29 and still see the problem, so it's somewhere
> in org.
>
> -- 
>
> Thanks,
>
> --Raman(I Search, I Find, I Misplace, I Research)
> 7©4 Id: kg:/m/0285kf1  •0Ü8

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 455 bytes --]

also for org developers:

The documentation for the org-fold customization says "use overlays for
third party packages that haven't updated support" or something to that
effect.

Would be nice from  a discoverability point of view for it to say right
there, or provide a pointer to something that says what third-parties
should actually do.

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> also for org developers:
>
> The documentation for the org-fold customization says "use overlays for
> third party packages that haven't updated support" or something to that
> effect.
>
> Would be nice from  a discoverability point of view for it to say right
> there, or provide a pointer to something that says what third-parties
> should actually do.

Please check ORG-NEWS. "Important announcements and breaking changes"
section.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1069 bytes --]

I think I made some progress chasing this down:

1. Problem: With Emacspeak as implemented, org-fold-core-style set to
   text-properties  results in hidden links being spoken.

2. The underlying cause appears to be how  copying such text into
   another buffer works.

3. Emacspeak implements its core speech logic by copying over what is to
   be spoken (text) to a scratch buffer, pre-processing it, and then
   doing its work.

4. The "invisibility" gets lost in the new org fold implementation.

See here for the relevant logic and code.

I verified that the copy/insert  to be the problem by:

A. Open an org file with a link in it with org-fold-core-style set to
   text-properties.
B. Set mark and do 
M-: (setq text (buffer-substring (point) (mark)))
C. Switch to a new buffer "foo"
M-: (insert-for-yank text)D. Insert: 
E. Move point to the portion of the link that should be hidden and  do
M-: (invisible-p (point)) Returns nil.
-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1027 bytes --]

Hi Ihor,

After looking through the code in org-fold-core.el,
I see the following:

org-fold-core.el: Line 1413

The comments in that section talk about preserving/not-preserving
folding when copying among indirect buffers.

But the lines at the afore-mentioned position indicate that the solution
for how to do this  when  pasting to a non-indirect buffer.

Note that emacspeak needs  a solution to the above,  --- at present,
when it tries to speak a folded line in org-9.6 with org-fold-core-style
set to text-properties, the invisibility gets lost, which is why content
that is folded in the original buffer gets spoken by emacspeak.

While we wait for a clean way for a third-party app to handle this, can
you tell me what I need to do on my end, e.g. perhaps inherit some magic
property from the source buffer into the scratch buffer where I
manipulate the text before speaking it perhaps?



-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1888 bytes --]


Hi Ihor,

Could you please this to the relevant folks on the org devel team?

I solved my issue with org folding in org-9.6 when org-fold-core-style
is set to transparencies -- TL;DR:

I created myself a small function by cloning function org-mode and
taking out most of the code so that what I had left were the bits that
set up org-fold magic; I then call this function in my code where I
create a temporary buffer for processing the text to speak. 

A better solution might be for org itself to provide such a function; my
initial solution was to just call (org-mode) but that function does a
lot of work that isn't needed just to set up the fold hiding bits.

See
https://github.com/tvraman/emacspeak/blob/master/lisp/dtk-speak.el#L1662
for the relevant code.

"T.V Raman" <raman@google.com> writes:
> Hi Ihor,
>
> After looking through the code in org-fold-core.el,
> I see the following:
>
> org-fold-core.el: Line 1413
>
> The comments in that section talk about preserving/not-preserving
> folding when copying among indirect buffers.
>
> But the lines at the afore-mentioned position indicate that the solution
> for how to do this  when  pasting to a non-indirect buffer.
>
> Note that emacspeak needs  a solution to the above,  --- at present,
> when it tries to speak a folded line in org-9.6 with org-fold-core-style
> set to text-properties, the invisibility gets lost, which is why content
> that is folded in the original buffer gets spoken by emacspeak.
>
> While we wait for a clean way for a third-party app to handle this, can
> you tell me what I need to do on my end, e.g. perhaps inherit some magic
> property from the source buffer into the scratch buffer where I
> manipulate the text before speaking it perhaps?

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
7©4 Id: kg:/m/0285kf1  •0Ü8

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> While we wait for a clean way for a third-party app to handle this, can
> you tell me what I need to do on my end, e.g. perhaps inherit some magic
> property from the source buffer into the scratch buffer where I
> manipulate the text before speaking it perhaps?

Maybe just a simple `org-copy-visible'?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> Could you please this to the relevant folks on the org devel team?

I am the relevant guy :)
Sorry for the delay, I am moving countries now.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

This may be an org-mode bug:

If you have '_' chars in a URL, they dont appear to turn invisible in
org mode :

Try as an example
put  this  in an org buffer:

for my [[http://awards.acm.org/award_winners/raman_4110221.cfm][PhD]].
This release

Notice that the parts with '_' remain visible.
Turn the '_' into a '-' and org folding appears to do the right thing.

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

--

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

Re: org-mode 9.6 and Emacs Built from Git HEAD

[Ihor Radchenko]

"T.V Raman" <raman@google.com> writes:

> Try as an example
> put  this  in an org buffer:
>
> for my [[http://awards.acm.org/award_winners/raman_4110221.cfm][PhD]].
> This release
>
> Notice that the parts with '_' remain visible.
> Turn the '_' into a '-' and org folding appears to do the right thing.

I am unable to reproduce using Org 9.6 and emacs -Q.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

Suspect this time it's being caused by some other org or other
package, doesn't repro with emacspeak -q either.

-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

--

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

Re: org-mode 9.6 and Emacs Built from Git HEAD

[T.V Raman]

Doesn't repro with emacspeak -q either --- so this time it's must be
some other package I have that's biting.


-- 

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮

--

Thanks,

--Raman(I Search, I Find, I Misplace, I Research)
♉ Id: kg:/m/0285kf1  🦮