From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 dc78779c0c: Fix SVG scaling (bug#59802) Date: Sat, 17 Dec 2022 09:26:08 +0800 Message-ID: <87tu1ug6rz.fsf@yahoo.com> References: <167120580083.8436.12355011753442988358@vcs2.savannah.gnu.org> <20221216155001.8BDCAC0060F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15038"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Manuel Giraud To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 17 02:27:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6Lyl-0003mp-TG for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Dec 2022 02:27:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6Ly5-0002UI-Qd; Fri, 16 Dec 2022 20:26:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Ly3-0002Tu-Tk for emacs-devel@gnu.org; Fri, 16 Dec 2022 20:26:23 -0500 Original-Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6Ly1-0005pK-Pb for emacs-devel@gnu.org; Fri, 16 Dec 2022 20:26:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1671240379; bh=gRaJSHMDhQs5O+pT+MGmPFb41DXakJ/AxhvNRbXA0s4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=PPT7ycHKRFOFv7ndvsKjh5fRDzQ8JKEbF+u3e71uoxaeQcvFOAsvoJNmEmWvmWGI5MXwrL1SPIm4ZVx1BLvP4ORzi0bVKWyeYfPNt5VVWRvQAwFw4yknCUJz22kiQsFsLnU71C7Bw1K2OLvUKIdDIBBFowq8zChcmlffUgms16Ai2OZ3nNTHR8SE3aRVooiXQdC3xGFUROrdsMjjiiknes5Imslz1a01ZA32v6V1KA0hPQ+MTaOM6HpP91pbagW19L/i+hrvgBpHFuliDxzTVi7NubQN0MhQ3eUSbqgoscgl+fXVOjbqIRRPprm0vwKxfzQmRODVi0RJrHsjGVUUnw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1671240379; bh=niRBXAhx2lUiIEBUPxESlPbakh38rixmNfUroFpHnIK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=IgMEOA6pKU01S4pP7imeXplrHgy3CynsKNgVZMWPHg+unk7zG2Bo2T1YrDbOz7zTfSl8DX0KXbhZ28EOkMiombmDX+FA+sufor4oBudKJMahkVk5vZihhyRUF7dPsCGGAC30fEYVPlSKS76HWSkWYDazWInlk9oMYagTlHB3tpg7VlZ0SI+CfhcKWOA9h9dEfqTWII29ghdf02I0A4aP0RRyzEq4EzVap9c4NUdutjygmbAhhVI7jiD14akJZXp0jRhra0B8veHzk8p90d6pMrfQbjXUZVsiBRvHShwx1fyhjSkFMl6LXg9uCzUGxqIdmGvfjyylAEB7g71wpJA8VA== X-YMail-OSG: tLsTt4MVM1lpPX_dRluUHfM9J8UTrGNKOu_nMwER_dn9BMNjC8oahmqsKK31XDk qkHF4w9ks57JKVDlNP7QJD6.n5B_XoE5QD.GV2nhniow7sOsaQETmY5VJ_eOrOvvT13K84HDIthp xBE1rW4HSVW5jaHMaRHCDjidzTdz2Lt7qOqWpTPpH3erVsBmSrvO3GgL1a1GtPByPaoY1qkh10HS sUA7s.9Yn6EOEIlgjIBGfEkN0VC7cOZIyVKLilXcqdmJcnKXIZAOLUUIn4bOyhYlNeNnWJoAnyfO fZkMBokRyTpx0SXvAj3uUIT.KzlGCeWyIQ36QUWESDWqGNJPd2cHRlQ1VPWgeMShLL2DJXMcDEgm oHy1cEPLMNxQuFuAINFiMugIgdQcu2zsUN_emFGLKnHbKqiZ_ZO1p.40NAQUT0jiiNMGUNZdwmdo r5GGZlm_sQvf2ffg.zGmOxbra7ZvfydAFBnnHUW8qTrwOdpwoBLr_f3QR1OxqgV7DPo7tkgmfYUQ GbqZai1sdNc5S_sxjF8F5dMDDKm_gbodjpTHeWxi5mI88X1eyjSrDkfvkYUSPhrZyyw868GNU.TB RyJE3dfvDcCp2QfTF.qVmbY1Kgaz7IAV8UD_6zswmlhcwkgDVbsPM5Nc1uqtii_.yRD6E0SMoAMR bJZ9vZCyhpvLSbZN7dr3hhaC562YCqhu6lFqfq6Jn2DefnMP5lRsvj1y7p_sn1UXSXm20X7iMdn4 Dqd28G9.ZFkUXgIwY_8uJRVMssYiuhTVbMiBgdk_PiF6QYk4WaK.14nsK2UNOQEI.mhYH7yRsDWw BgH3HHOlhlFFuEUcq3W7kENd4GQQwOJQZC7su4Z5NU X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sat, 17 Dec 2022 01:26:19 +0000 Original-Received: by hermes--production-sg3-b666c6484-bfm47 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 31d63a151ab258975968bc39e69fe58b; Sat, 17 Dec 2022 01:26:14 +0000 (UTC) In-Reply-To: <20221216155001.8BDCAC0060F@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 16 Dec 2022 10:50:00 -0500 (EST)") X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.147; envelope-from=luangruo@yahoo.com; helo=sonic314-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301534 Archived-At: Eli Zaretskii writes: > + if (! (0 < viewbox_width) && (iwidth.unit == RSVG_UNIT_PERCENT)) > + viewbox_width = (viewbox_height * viewbox.width / viewbox.height) > + * iwidth.length; > + else if (! (0 < viewbox_height) && (iheight.unit == RSVG_UNIT_PERCENT)) > + viewbox_height = (viewbox_width * viewbox.height / viewbox.width) > + * iheight.length; Our style is to write: viewbox_width = ((viewbox_height * viewbox.width / viewbox.height) * iwidth.length); and not: viewbox_width = (viewbox_height * viewbox.width / viewbox.height) * iwidth.length; Thanks.