From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felix Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] change dired--find-possibly-alternative-file behaviour. Date: Sun, 26 Feb 2023 07:32:27 +0100 Message-ID: <87ttz9gceo.fsf@web.de> References: <87mt51o5bu.fsf@web.de> <83ttz9j8up.fsf@gnu.org> <87y1olgdca.fsf@web.de> <83h6v9j5xm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1244"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.3; emacs 30.0.50 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 26 07:42:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWAjd-0000A8-Jj for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Feb 2023 07:42:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWAiu-00072C-1j; Sun, 26 Feb 2023 01:41:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWAii-000722-QB for emacs-devel@gnu.org; Sun, 26 Feb 2023 01:41:16 -0500 Original-Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWAig-00075D-Li; Sun, 26 Feb 2023 01:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677393672; i=felix.dick@web.de; bh=c41OVL1xdMQBzHFs/lez6w62Mjws3fhZ6zN8kzSn9uc=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=mGvSgCDePee6RbOqOg07O7Ca2b+s83nyZMKnFsuCCNQu3iImaG4m624rzKwTCjCmc HHgQBq/qgTNgbYp895OnOaBTmgY7SYOKbJ9c/xpznTLlYXBAIwMj13rtkzKbBpF/GH lXJPrhCliIB0yLc+a4mtFyi/C4qvD/mons8MXP/Z8c88Lg+8/CKKrqRma7Gc7UpJ7E SMnUJQpoSTcF6Qh99ISeqliYjvKr4B9riGlF+lEGSZId26U/4/h3dW+T4BfFDvFU7g 9JFXhcD7pZzwszeWA63ElhHIGwDiVZcJuPsY7BwU44oWiZsLg6JuwK7o6J1KODJ6JE XVUkh0H8ZbTzw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from felix-lifebooka531.web.de ([95.91.210.207]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MlL9z-1onAGb06RB-00lIl5; Sun, 26 Feb 2023 07:41:12 +0100 In-reply-to: <83h6v9j5xm.fsf@gnu.org> X-Provags-ID: V03:K1:iR4v4nI4u6gLcofzpBF96lBoXo8enuUqbGPd91D1HZffbUncib5 qGf9F/xjpg+/viW2gIn7Zoz34dgERyy9iKDPKYLhp1DGe/ZadcM6carELqNUhF1wwaGUnlE urcdVdUD/QXZAkWyVVe2ZI5EYAE9iPGuNTG8jWozY6knN7pSiEK0PRjbrYv2TBE9phsqumY OkRZ9WJbCXJxTxWrJKXfw== UI-OutboundReport: notjunk:1;M01:P0:KJKphcYAkag=;275M1B3vZNkeeQsLH1MSuZrZOUh g4aaPZorHJMkLBDBkw5KyjWXD9vsl0/26IfPD0KowbTqR+1GtUXn46/rc3bv1qYKtlz7t8MBC iw8wkWrKXyimW6KBuWRUS96BUjRsPqZUDtngyRdGovjxszk6Uj3JrugVh1EzqweKsUzy1blD+ EyqNegtLC41ORojJoXhNf4FiLXbAaXzacawe3Rhd8CfONBJaoJn+1PLuFodjNHXwvvjSchcfE EcNQUmI2S0MFy+VJgK+PkpiVt0JJWPRsAHpSKoQBM74brjRLStAHz6UMiCEiqgogNs1RFq2PF rnadHxs+SrL5BZTFux7q3FxbxxARYsH+QM8COztlGz7xKx3LSwsdsVW7AmFSu7zy/fOYah0q4 HSC/WzGlBAJNZONnoAox/g6b9mFJEc6m0WDPZlofzoi3LX9kUleIN8HYjXXnrOxeWby7PlcVC fT5MMtZMrCZig1wn0zcUV7f7y65Wgb6NWaJerLvS66mDMoyyYC9D+M9LM00T313LONrg5rOgU 0B3cWEVlVm1mYm1cAgEI7ca7y0XkVS/SShvZLkqSI29l/+x6y0g7FfJcIler8Pai3CCaZs/fy lSNz0T/d9hFGNmjvdjiq2dd+i9t1v5zvrHl9T9A8/r82eBtZbQJgB5RCOkkzG6orBjVNYSdNL 7IXe6BDa+PVigFXvjPs5FWpKqc+QrjddqV4QBiwQCDe/r0woDbJF7CMhllhm/qaYaxKLNbgHc QObLh+5c03hN0gp041bE65yaz+u6IcqJ+8Jgu3DZ5Ps+C/6uLC7FnW7MaAL457icAOe6W3hU Received-SPF: pass client-ip=212.227.17.11; envelope-from=felix.dick@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303813 Archived-At: Eli Zaretskii writes: >> From: Felix >> Cc: emacs-devel@gnu.org >> Date: Sun, 26 Feb 2023 07:07:10 +0100 >> >> >> Eli Zaretskii writes: >> >> >> From: Felix >> >> Date: Sat, 25 Feb 2023 20:43:57 +0100 >> >> >> >> diff --git a/lisp/dired.el b/lisp/dired.el >> >> index 76499d0f520..620508bef4f 100644 >> >> --- a/lisp/dired.el >> >> +++ b/lisp/dired.el >> >> @@ -2728,7 +2728,8 @@ dired-find-file >> >> (defun dired--find-possibly-alternative-file (file) >> >> "Find FILE, but respect `dired-kill-when-opening-new-dired-buffer'." >> >> (if (and dired-kill-when-opening-new-dired-buffer >> >> - (file-directory-p file)) >> >> + (file-directory-p file) >> >> + (= (length (get-buffer-window-list)) 1)) >> >> (progn >> >> (set-buffer-modified-p nil) >> >> (dired--find-file #'find-alternate-file file)) >> > >> > What if get-buffer-window-list returns nil? >> >> The optional argument BUFFER-OR-NAME of get-buffer-window-list defaults >> to the current buffer, shouldn't that garantee that it never returns >> nil? > > Only if the current buffer is displayed in some window. If get-buffer-window-list returns nil for any case, (length nil) returns 0. In that case the if condition is false and dired--find-file will not kill any buffer. Is there a possible case where the function is called from dired buffer, and get-buffer-window-list returns nil? In that case the buffer would stay alive! dired--find-possibly-alternative-file is only used in 2 places dired-find-file and in dired-up-directory. I thought those functions are only useful inside dired buffer windows.