From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Sun, 05 Mar 2023 20:06:46 +0800 Message-ID: <87ttyzs8q1.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87zg8uw9b9.fsf@yahoo.com> <837cvycjse.fsf@gnu.org> <87ttz2w4c3.fsf@yahoo.com> <83356mcbxw.fsf@gnu.org> <87pm9qvu9w.fsf@yahoo.com> <83y1odc37g.fsf@gnu.org> <87cz5pwf9c.fsf@yahoo.com> <83edq5asb3.fsf@gnu.org> <875ybhvt4w.fsf@yahoo.com> <83356kbxnh.fsf@gnu.org> <87lekcvho4.fsf@yahoo.com> <83r0u4adgd.fsf@gnu.org> <87a60suknn.fsf@yahoo.com> <83356jafll.fsf@gnu.org> <87o7p7tz16.fsf@yahoo.com> <83sfej8v17.fsf@gnu.org> <87fsajtrrx.fsf@yahoo.com> <83o7p78ns8.fsf@gnu.org> <87y1obsamf.fsf@yahoo.com> <0100f288-fcc0-8b91-5f12-18bf22969e50@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 05 13:07:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYn8u-000A6z-Bw for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Mar 2023 13:07:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYn8o-0007wa-PC; Sun, 05 Mar 2023 07:07:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYn8m-0007wE-MZ for emacs-devel@gnu.org; Sun, 05 Mar 2023 07:07:00 -0500 Original-Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYn8k-0007Mh-I9 for emacs-devel@gnu.org; Sun, 05 Mar 2023 07:07:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678018015; bh=pPZOTCpKdSpAAXiraO+ygMGPwJgXnWa1N799Dffpuvk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=J/RDpqxRuMwRjRNvBVMbOv0GkebkYHhKbJDmOVHlln2vJU2DRlBIcT5yahbAGINKBqWyyrkYN/off7TnKlH5fK2RgoqdyTjaNts1SJZ6ADarp4CHKMt0iNo5UpQaX+fLXn4SSw6E3qGxrDKSYakfe21ogdsOjq1sf1OrkgIpX8ZEuzNW4mG11AviElLjEE3x4Pr3CJ2qH0BYN2tw1T8NGBQGqWZBRbdXcRrqUYxoFMHvI1yuk2YjtVpd72QGIdeyT2xLYnvIsEBeX3ID1JX7iBk6QWbJ4XeK3CwPtqbWxuKDVPGM4E3mApp/Y2PwbmVj4R85yxPD9WdkiPB4/dZm2Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678018015; bh=cZlnq8ePU9tjoVMqjUBaQyOd9iqt9YVZtiUgkWSaNDb=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=UbobK7AWObYkitAstcgNZ+1/2qdX2XFeYML5TbzDbKsAenc4ywIGOOzdkDqJUGxW/eAZee9Yq7VSV4JA3mBiGpa6gQ7wf6plrdcRCCUUfpKku5AaVtVFUcDe5FR4k6BxHCuIq6Ad35iilF1qXI9Maf5t6fe0FbBU2G4Qt9YmNw86kjXQkWSTLpWMmYxZGMPeuV/H68ebT2cK2WpdUY+k+IG3I5vZ641VrqF+DbPyMHq7r1mvYSOSyGavh0jNZja3y6IuLsC2TFdqf2lXLp6BfEsLGiwVHy9+cLS8exBmmNCLJWCjt8pgBgl24QcKrqrk2CFBBxqS76/25/rp5+mBtw== X-YMail-OSG: HqfhNScVM1krv5dTMiQfgC4sXXtq5RaGkOo9gUdQMoQkyeOOtmRiFVFvH21OWMH _DMd4ue76xX38qap0l9aar_gclDoI9vvwxBgfaaLo9Wu6ZYRII5MRJeMm0bWizyt3PD_UyX.T.uX ySBJX3jQ5IXGwWm4ikPFRMF8JZlmmllGNG_stFIoGuNBT2lmZfpu4kOw0ak3pVzz.hhDJ77l2DyS qpr28XNZ.xEPJbmoISyAaq0TqZXYHMkfdildG87x0BBMNJXiRPVwZW.mRkeW7uxWCL1OiPfQEC81 PF6acozGeehp_g0iyOWUnBU7gIzBz6IgX_l3G4goXjaYfpomNqsvhQrIZjVLue8HlgoVzFaUw4Lt OQyVYzs_MKQ_RzmON5vpzuacKF94YXxry_Ehtk7izFcQJUTz7EQu1uz9qnlCdn7nDcL.0CEf_8dp ad0HE0iJ_IjqMjmqrQBwKST11X.2eBH7D65QVflnqQ9i2WpZ.VZ.GRfiR5SxauitutXoKUAPNT0P 1p3PoL8p9LNOh_meBTLZI3Gpo6ASClKzVicqujz9_hQOkjsSBeWTrokZJuPne829bfi0CEjpi45K y9nWl_wCLm6bI_vf1z00ayyleNjpgPHe1PgpDMOoeKn.XMg_Z4bJbZjfc6S2GBj.awvbb.6IEk1t y1h48ZLpNPLwxF1cR74.O.CvwamBVu7VGDDPQD8pbrW0MMOZ4E.qvGMlnnG6lnyse232mOQTcIq_ L1DDKwHAOS1Xswv5pVzSHSM5PFRNymS68uri_D4TNEJwk3BEwbOF72UAUwuVpvKRUR.P0bJezvYZ 2JXoqlZocUIziZOCzdzQ9XKvPV491ajOLcHXrzMNhH X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 5 Mar 2023 12:06:55 +0000 Original-Received: by hermes--production-sg3-67c57bccff-sjmln (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 55b8b7ebb74ecfa3e1aa0c83ef3aa89c; Sun, 05 Mar 2023 12:06:51 +0000 (UTC) In-Reply-To: <0100f288-fcc0-8b91-5f12-18bf22969e50@cs.ucla.edu> (Paul Eggert's message of "Sun, 5 Mar 2023 03:38:13 -0800") X-Mailer: WebService/1.1.21221 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.146; envelope-from=luangruo@yahoo.com; helo=sonic316-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303981 Archived-At: Paul Eggert writes: > As I recall there wasn't much discussion, unfortunately. I very > vaguely recall that there was some worry that Emacs modules would be > written in C++, and that they would invoke Elisp code, and that this > meant it'd be hard to do the cleanup in portable C. > > One option that was discussed was to require a C++ compiler to compile > emacs-modules.cc (i.e., to write the emacs-modules interface in > C++). I expect this would have addressed the cleanup issue in a > different way. But RMS was very strongly against requiring a C++ > compiler. We build emacs with -fexceptions? That's the only case where GCC turns: foo () { type *k __attribute__((cleanup, cleanup_func)); k = /* ... */; } into something other than: foo () { type *k __attribute__((cleanup, cleanup_func)); k = /* ... */; cleanup_func (k); } and I really hope we are not building emacs with -fexceptions, because it really generates a lot of extra code that increases binary size. > You may find this patch useful: > > https://lists.gnu.org/archive/html/emacs-devel/2019-04/msg01075.html This is essentially what was installed on feature/android (except that check also works while cross compiling, and is only run when modules are enabled.) This says that the change was dismissed by virtue of modules being disabled by default, but now that has changed, so wouldn't it be the right time to reconsider the ``makes configure slower'' argument? BTW, with a cache file, you only pay the price of the test once.