From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] sql: add missing postgresql types Date: Mon, 17 Apr 2023 11:12:32 +0200 Message-ID: <87ttxeeutb.fsf@gmail.com> References: <20230416133843.74970-1-nicolas@n16f.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4819"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Nicolas Martyanoff Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 17 11:13:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poKva-00011r-0u for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Apr 2023 11:13:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poKug-0007Po-7u; Mon, 17 Apr 2023 05:12:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poKud-0007OJ-Ef for emacs-devel@gnu.org; Mon, 17 Apr 2023 05:12:39 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poKub-0000m5-4n for emacs-devel@gnu.org; Mon, 17 Apr 2023 05:12:39 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f167d293c7so7763045e9.2 for ; Mon, 17 Apr 2023 02:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681722754; x=1684314754; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=e1PVFQxlE6M4QOYA5qLPchaa0+513tZnytXQgmsuAd4=; b=KqcnhuoASH3a6hNjzW7552su69NRQkFaEjovgZO0mTHSd8FujH+CaSEW2ZQxrIgGhK koNa1NWQG4pswNIeHBXAjjvXriKijA1gIvPRF4Fnv2r9ONfIOmDOSyvR0aIVSjjBljmv YvGmMmXQqfpv8qVWkUqxHmWo9GyppUTf5xN4XH7TDqH4Pnca4gozEbbFeV8QT6IUivLF OK9bhuLJ5FBojEGMCRnbkX5oS7emKVcJkdGT2gdTzYqZVw1x0MuL8k1Osi7mSZsqpstt aoBvjh/ZsQfJAlCuZby7fenlrlTpF2xOi/ufEqsrlE6VPN2oqjxEHiVguU5aR8JVfO+6 v7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681722754; x=1684314754; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1PVFQxlE6M4QOYA5qLPchaa0+513tZnytXQgmsuAd4=; b=SlvSZ1sHMTUCMaBC5+OGkcZt6Lr13/Xf7NmU0T8qTvO5AjXWPlAltINZa7m63yHvbz SzXYWSQoXWxDI57AjkfnRKB0n6Hn1GBm4V80edfv/peVmDCdpJpEEVrvFiiOUTZ1K5CZ T8lnB3AaHZCTXam864ffMrF/sCDwnwF8INRFUisEL3/yvfpDge0o1803R6Npa65inYoz l4IX9fylN/3qOVW9DTTLCKkjEfMqjdvpiRD0MnI0sg5A1XKCCfAaYzpIoLyjSfxXqsDY 3rM7QwHT+jDssMrBtyI0lQNCEG/W8Pa1ol0ORqKN7IWGQFic+HP9b2T1beHmJno7F2y1 s9TA== X-Gm-Message-State: AAQBX9dLLhCyUgjmbx7dMXouuC3wKCw/RiI57ROhG3qNjJBqOE6/tDfT T7DslZQ5WBjbhXNYorgYQT9lp4J2dD8= X-Google-Smtp-Source: AKy350aKwC9ZBn9J7LeZGn7wsTbX4xPyPgUty6g9K8jw7qGPHnxNcjlWwS6Q4uwZwtSUWeWweXL2Dw== X-Received: by 2002:a5d:574a:0:b0:2ef:b8d1:9560 with SMTP id q10-20020a5d574a000000b002efb8d19560mr5276786wrw.30.1681722754133; Mon, 17 Apr 2023 02:12:34 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r4-20020adfda44000000b002f598008d50sm9972738wrl.34.2023.04.17.02.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 02:12:33 -0700 (PDT) In-Reply-To: <20230416133843.74970-1-nicolas@n16f.net> (Nicolas Martyanoff's message of "Sun, 16 Apr 2023 15:38:43 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305361 Archived-At: >>>>> On Sun, 16 Apr 2023 15:38:43 +0200, Nicolas Martyanoff said: Nicolas> * lisp/progmodes/sql.el: Add multiple missing PostgreSQL types: bigserial, Nicolas> smallserial, macaddr8, jsonb, jsonpath, built-in range types, object Nicolas> identifier types (oid & co). Nicolas> --- Nicolas> lisp/progmodes/sql.el | 19 +++++++++++-------- Nicolas> 1 file changed, 11 insertions(+), 8 deletions(-) Nicolas> diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el Nicolas> index d8bd6bc2685..75d0cbbb367 100644 Nicolas> --- a/lisp/progmodes/sql.el Nicolas> +++ b/lisp/progmodes/sql.el Nicolas> @@ -2192,14 +2192,17 @@ sql-mode-postgres-font-lock-keywords Nicolas> ;; Postgres Data Types Nicolas> (sql-font-lock-keywords-builder 'font-lock-type-face nil Nicolas> -"bigint" "bigserial" "bit" "bool" "boolean" "box" "bytea" "char" Nicolas> -"character" "cidr" "circle" "date" "decimal" "double" "float4" Nicolas> -"float8" "inet" "int" "int2" "int4" "int8" "integer" "interval" "line" Nicolas> -"lseg" "macaddr" "money" "name" "numeric" "path" "point" "polygon" Nicolas> -"precision" "real" "serial" "serial4" "serial8" "sequences" "smallint" "text" Nicolas> -"time" "timestamp" "timestamptz" "timetz" "tsquery" "tsvector" Nicolas> -"txid_snapshot" "unknown" "uuid" "varbit" "varchar" "varying" "without" Nicolas> -"xml" "zone" Nicolas> + "bigint" "bigserial" "bigserial" "bit" "bool" "boolean" "box" "bytea" "char" Nicolas> +"character" "cidr" "circle" "date" "daterange" "decimal" "double" "float4" Nicolas> +"float8" "inet" "int" "int2" "int4" "int4range" "int8" "int8range" "integer" Nicolas> +"interval" "jsonb" "jsonpath" "line" "lseg" "macaddr" "macaddr8" "money" Nicolas> +"name" "numeric" "numrange" "oid" "path" "point" "polygon" "precision" "real" Nicolas> +"regclass" "regcollation" "regconfig" "regdictionary" "regnamespace " Nicolas> +"regoper" "regoperator" "regproc" "regprocedure" "regrole" "regtype" Nicolas> +"sequences" "serial" "serial4" "serial8" "smallint" "smallserial" "text" Nicolas> +"time" "timestamp" "timestamptz" "timetz" "tsquery" "tsrange" "tstzrange" Nicolas> +"tsvector" "txid_snapshot" "unknown" "uuid" "varbit" "varchar" "varying" Nicolas> +"without" "xml" "zone" Nicolas> ))) You have 'bigserial' in there twice. Robert --