From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Sat, 17 Jun 2023 13:05:52 +0000 Message-ID: <87ttv69r2n.fsf@localhost> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> <87sfbasr8m.fsf@web.de> <87y1l244hz.fsf@localhost> <87o7lxpip9.fsf@web.de> <87wn0lkkod.fsf@localhost> <87leh02iqx.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10374"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 17 15:02:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAVZ5-0002Ug-Bu for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Jun 2023 15:02:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAVYG-00020h-MP; Sat, 17 Jun 2023 09:01:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVY7-00020N-Oh for emacs-devel@gnu.org; Sat, 17 Jun 2023 09:01:06 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVY4-0007Jy-B7 for emacs-devel@gnu.org; Sat, 17 Jun 2023 09:01:03 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 16314240027 for ; Sat, 17 Jun 2023 15:00:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687006858; bh=8PK8TJqd8Q2/6cm8wuvmHPYzL8/Pkn3rroxB9jIs6Sc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=KiuqLTe3694dyeZO9G6Xw2gZxi+VpXoaWEM5BjTz61kbAr+VM/vTdAr1mlDSgu6rK 753Cp+XKf+nlS4oHWrZln1bJQJuP9qoXtRoWDu3c7YF6NNRZpucLoCe9taaqDlFHrJ h3sk9JiJ05xNT5JkDOczU9QgADe3VaqYBlARPdjTsI+TQOqY3dTOnD6FhGQCAlbifo 0dW0ATF7kYBEouSBOPEssrIo7ohcII+mECAisqzojHP58WvC0dwIeSesX3hQnc2e3/ qgglhgPNVQR0AdWGOZdixwjcMFN0ZIpWkEjXIdJFPHtu9pHA+IhRYzUh4QunvbkOaM WAF3pMivEFRkA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qjx3Y40Q4z9rxL; Sat, 17 Jun 2023 15:00:57 +0200 (CEST) In-Reply-To: <87leh02iqx.fsf@web.de> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306879 Archived-At: Michael Heerdegen writes: >> May you please elaborate? I am not sure what `kill-variable' calls you >> are referring to here. > > To those in `wdired-change-to-dired-mode: > > #+begin_src emacs-lisp > (when wdired-search-replace-filenames > (remove-function (local 'isearch-search-fun-function) > #'dired-isearch-search-filenames) > (kill-local-variable 'replace-search-function) > (kill-local-variable 'replace-re-search-function) > ;; Restore dired hook > (add-hook 'isearch-mode-hook #'dired-isearch-filenames-setup nil t)) > #+end_src > > This demonstrates a problem when not using an advice: to get rid of the > temporary new binding you simply kill the local variable, but this can > be problematic, especially when we did not create it (but maybe someone > third). The code above is indeed slightly problematic. I'd store the old value somewhere in such situations and restore later. May `define-advice' be modified to work on variable values? That way, one can override the variable value and later restore the old one using the existing machinery. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at