* Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
[not found] ` <20230629071745.70945C19274@vcs2.savannah.gnu.org>
@ 2023-06-30 9:32 ` Michael Albinus
2023-06-30 17:51 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2023-06-30 9:32 UTC (permalink / raw)
To: emacs-devel; +Cc: Juri Linkov
Juri Linkov <juri@jurta.org> writes:
Hi,
> * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
>
> * lisp/misc.el (duplicate-line): Use it.
>
> * test/lisp/misc-tests.el (misc--duplicate-line): Add tests for
> duplicate-line-final-position.
When running the tests with native compilation, there's an error:
--8<---------------cut here---------------start------------->8---
ELC+ELN lisp/misc-tests.elc
In toplevel form:
lisp/misc-tests.el:95:12: Warning: Unused lexical variable `duplicate-line-final-position'
lisp/misc-tests.el:102:12: Warning: Unused lexical variable `duplicate-line-final-position'
GEN lisp/misc-tests.log
Running 7 tests (2023-06-29 18:20:46+0000, selector `(not (tag :unstable))')
Mark set (rectangle mode)
passed 1/7 misc--duplicate-dwim (3.970630 sec)
Test misc--duplicate-line backtrace:
signal(ert-test-failed (((should (equal (point) 12)) :form (equal 7
ert-fail(((should (equal (point) 12)) :form (equal 7 12) :value nil
#f(compiled-function () #<bytecode -0x4c32571230de989>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name misc--duplicate-line :documentation n
ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/misc-tests" "--eval"
command-line()
normal-top-level()
Test misc--duplicate-line condition:
(ert-test-failed
((should
(equal
(point)
12))
:form
(equal 7 12)
:value nil :explanation
(different-atoms
(7 "#x7" "?\7")
(12 "#xc" "?\f"))))
FAILED 2/7 misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:83
passed 3/7 misc-test-backward-to-word (0.000207 sec)
passed 4/7 misc-test-copy-from-above-command (0.000132 sec)
passed 5/7 misc-test-forward-to-word (0.000131 sec)
passed 6/7 misc-test-upcase-char (0.000114 sec)
passed 7/7 misc-test-zap-up-to-char (0.000278 sec)
Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000, 4.174909 sec)
1 unexpected results:
FAILED misc--duplicate-line ((should (equal (point) 12)) :form (equal 7 12) :value nil :explanation (different-atoms (7 "#x7" "?\a") (12 "#xc" "?\f")))
--8<---------------cut here---------------end--------------->8---
See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69705>.
Running the tests w/o native compilation don't show that error.
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
2023-06-30 9:32 ` master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185) Michael Albinus
@ 2023-06-30 17:51 ` Juri Linkov
2023-07-01 7:46 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2023-06-30 17:51 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>> * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
>>
>> * lisp/misc.el (duplicate-line): Use it.
>>
>> * test/lisp/misc-tests.el (misc--duplicate-line): Add tests for
>> duplicate-line-final-position.
>
> When running the tests with native compilation, there's an error:
>
> ELC+ELN lisp/misc-tests.elc
> In toplevel form:
> lisp/misc-tests.el:95:12: Warning: Unused lexical variable `duplicate-line-final-position'
> lisp/misc-tests.el:102:12: Warning: Unused lexical variable `duplicate-line-final-position'
> GEN lisp/misc-tests.log
> Running 7 tests (2023-06-29 18:20:46+0000, selector `(not (tag :unstable))')
> Mark set (rectangle mode)
> passed 1/7 misc--duplicate-dwim (3.970630 sec)
> Test misc--duplicate-line backtrace:
> signal(ert-test-failed (((should (equal (point) 12)) :form (equal 7
> ert-fail(((should (equal (point) 12)) :form (equal 7 12) :value nil
> #f(compiled-function () #<bytecode -0x4c32571230de989>)()
> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> ert-run-test(#s(ert-test :name misc--duplicate-line :documentation n
> ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))
> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
> ert-run-tests-batch((not (tag :unstable)))
> ert-run-tests-batch-and-exit((not (tag :unstable)))
> command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/misc-tests" "--eval"
> command-line()
> normal-top-level()
> Test misc--duplicate-line condition:
> (ert-test-failed
> ((should
> (equal
> (point)
> 12))
> :form
> (equal 7 12)
> :value nil :explanation
> (different-atoms
> (7 "#x7" "?\7")
> (12 "#xc" "?\f"))))
> FAILED 2/7 misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:83
> passed 3/7 misc-test-backward-to-word (0.000207 sec)
> passed 4/7 misc-test-copy-from-above-command (0.000132 sec)
> passed 5/7 misc-test-forward-to-word (0.000131 sec)
> passed 6/7 misc-test-upcase-char (0.000114 sec)
> passed 7/7 misc-test-zap-up-to-char (0.000278 sec)
> Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000, 4.174909 sec)
> 1 unexpected results:
> FAILED misc--duplicate-line ((should (equal (point) 12)) :form (equal 7 12) :value nil :explanation (different-atoms (7 "#x7" "?\a") (12 "#xc" "?\f")))
>
> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69705>.
>
> Running the tests w/o native compilation don't show that error.
It should go away after updating autoloads.
I did `make autoloads`, and there is no error anymore.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185).
2023-06-30 17:51 ` Juri Linkov
@ 2023-07-01 7:46 ` Michael Albinus
2023-07-02 8:04 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2023-07-01 7:46 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel
Juri Linkov <juri@linkov.net> writes:
Hi Juri,
>> Test misc--duplicate-line condition:
>> (ert-test-failed
>> ((should
>> (equal
>> (point)
>> 12))
>> :form
>> (equal 7 12)
>> :value nil :explanation
>> (different-atoms
>> (7 "#x7" "?\7")
>> (12 "#xc" "?\f"))))
>> FAILED 2/7 misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:83
>> passed 3/7 misc-test-backward-to-word (0.000207 sec)
>> passed 4/7 misc-test-copy-from-above-command (0.000132 sec)
>> passed 5/7 misc-test-forward-to-word (0.000131 sec)
>> passed 6/7 misc-test-upcase-char (0.000114 sec)
>> passed 7/7 misc-test-zap-up-to-char (0.000278 sec)
>> Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000, 4.174909 sec)
>> 1 unexpected results:
>> FAILED misc--duplicate-line ((should (equal (point) 12)) :form (equal 7 12) :value nil :explanation (different-atoms (7 "#x7" "?\a") (12 "#xc" "?\f")))
>>
>> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69705>.
>>
>> Running the tests w/o native compilation don't show that error.
>
> It should go away after updating autoloads.
> I did `make autoloads`, and there is no error anymore.
It doesn't look like. See on emba.
There is the job build-native-comp-speed2. It does
--8<---------------cut here---------------start------------->8---
./autogen.sh autoconf
./configure --with-native-compilation
make bootstrap -j2
--8<---------------cut here---------------end--------------->8---
The next job, test-native-comp-speed2, uses the resulting docker
image. And it runs
--8<---------------cut here---------------start------------->8---
make -j4 && make -k -C test check SELECTOR='(not (tag :unstable))'
--8<---------------cut here---------------end--------------->8---
This job produces the error. See for example
<https://emba.gnu.org/emacs/emacs/-/jobs/69782>
<https://emba.gnu.org/emacs/emacs/-/jobs/69783>
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-02 8:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <168802306502.18770.6910423069706438994@vcs2.savannah.gnu.org>
[not found] ` <20230629071745.70945C19274@vcs2.savannah.gnu.org>
2023-06-30 9:32 ` master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185) Michael Albinus
2023-06-30 17:51 ` Juri Linkov
2023-07-01 7:46 ` Michael Albinus
2023-07-02 8:04 ` Michael Albinus
2023-07-02 8:07 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).