From: Po Lu <luangruo@yahoo.com>
To: sbaugh@catern.com
Cc: emacs-devel@gnu.org
Subject: Re: call-process should not block process filters from running
Date: Tue, 04 Jul 2023 12:09:14 +0800 [thread overview]
Message-ID: <87ttukqpw5.fsf@yahoo.com> (raw)
In-Reply-To: <87sfa4pjuu.fsf@catern.com> (sbaugh@catern.com's message of "Mon, 03 Jul 2023 21:04:57 -0400")
sbaugh@catern.com writes:
> /* Clean up files, file descriptors and processes created by Fcall_process. */
This is a stray comment.
> +struct synch_process {
> + /* If nonzero, a process-ID that has not been reaped. */
> + pid_t pid;
> + /* If a string, the name of a temp file that has not been removed. */
> + Lisp_Object tempfile;
> + int* callproc_fd;
> + Lisp_Object buffer;
> +};
Please place the opening brace of this structure definition on a new
line, fill the comments above each field, and write:
int *callproc_fd;
instead of
int* callproc_fd;
ISTM that this field could be named `fd' instead.
> + struct synch_process synch_process = {
> + .pid = 0,
> + .tempfile = make_fixnum (0),
> + .callproc_fd = callproc_fd,
> + .buffer = Fcurrent_buffer (),
> + };
Why not declare `sync_process' earlier? The code looks better that way.
> + wait_reading_process_output(-1, -1, 0, display_on_the_fly,
> + NULL, NULL, 0);
> + swallow_events(display_on_the_fly);
Please place a space between the function identifier and its parameter
list.
> if (display_on_the_fly)
> break;
> }
> @@ -904,7 +897,7 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
>
> /* Don't kill any children that the subprocess may have left behind
> when exiting. */
> - synch_process_pid = 0;
> + synch_process.pid = 0;
>
> SAFE_FREE_UNBIND_TO (count, Qnil);
>
> @@ -2035,11 +2028,6 @@ syms_of_callproc (void)
> #endif
> staticpro (&Vtemp_file_name_pattern);
>
> -#ifdef MSDOS
> - synch_process_tempfile = make_fixnum (0);
> - staticpro (&synch_process_tempfile);
> -#endif
Please make your modifications conditional on _not_ building the MS-DOS
port: as it is a single process ``operating system'', Emacs does not run
while a subprocess is running, so these changes are unnecessary.
I've also pointed out a general issue with this change: when a timer or
selection converter calls `call-process', it does not expect more timers
to run from within. Assume that a timer periodically calls `rm
/var/run/foo', and it takes a few seconds for `/bin/rm' to page in,
enough for that timer to run again. Now, one of the calls to `rm' will
fail and signal an error.
next prev parent reply other threads:[~2023-07-04 4:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 21:55 call-process should not block process filters from running Spencer Baugh
2023-06-28 11:39 ` Mattias Engdegård
2023-06-28 11:56 ` Po Lu
2023-06-28 12:08 ` Spencer Baugh
2023-06-28 13:17 ` Po Lu
2023-06-28 12:52 ` Eli Zaretskii
2023-06-28 13:27 ` Spencer Baugh
2023-06-28 13:34 ` Eli Zaretskii
2023-07-01 18:24 ` Spencer Baugh
2023-07-01 18:59 ` Eli Zaretskii
2023-07-01 19:17 ` Spencer Baugh
2023-07-02 5:45 ` Eli Zaretskii
2023-07-03 0:02 ` sbaugh
2023-07-03 10:00 ` Po Lu
2023-07-03 17:53 ` sbaugh
2023-07-03 18:51 ` Eli Zaretskii
2023-07-03 20:28 ` sbaugh
2023-07-04 4:12 ` Po Lu
2023-07-04 11:25 ` Eli Zaretskii
2023-07-04 12:42 ` sbaugh
2023-07-04 13:42 ` Michael Albinus
2023-07-04 14:16 ` sbaugh
2023-07-05 6:36 ` Michael Albinus
2023-07-04 11:10 ` Eli Zaretskii
2023-07-04 12:20 ` sbaugh
2023-07-04 13:09 ` Eli Zaretskii
2023-07-04 13:37 ` sbaugh
2023-07-04 13:25 ` Po Lu
2023-07-04 1:04 ` sbaugh
2023-07-04 4:09 ` Po Lu [this message]
2023-07-04 12:27 ` sbaugh
2023-07-04 13:22 ` Po Lu
2023-07-04 13:51 ` sbaugh
2023-07-04 16:38 ` Eli Zaretskii
2023-07-04 16:53 ` sbaugh
2023-07-04 17:14 ` Eli Zaretskii
2023-07-04 16:49 ` Dmitry Gutov
2023-07-04 18:12 ` sbaugh
2023-07-05 18:53 ` Dmitry Gutov
2023-07-06 2:24 ` sbaugh
2023-07-06 8:06 ` Michael Albinus
2023-07-08 15:54 ` sbaugh
2023-07-09 9:04 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttukqpw5.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).