From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: Optionally use copy-tree for cl struct copier Date: Sun, 10 Sep 2023 11:58:11 -0700 Message-ID: <87tts1luso.fsf@breatheoutbreathe.in> References: <8734zln9tp.fsf@breatheoutbreathe.in> <87y1hdluw4.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8885"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs Devel Mailing List , Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 10 21:00:50 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfPft-00025U-M7 for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Sep 2023 21:00:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfPfI-0001hF-05; Sun, 10 Sep 2023 15:00:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfPdp-0000ON-IW for emacs-devel@gnu.org; Sun, 10 Sep 2023 14:58:41 -0400 Original-Received: from out-221.mta0.migadu.com ([91.218.175.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfPdm-00044O-W8 for emacs-devel@gnu.org; Sun, 10 Sep 2023 14:58:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1694372316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xKsrn3wLl13UMVZiY7p6CNf6eSapid+PRrGTQXO+rJ0=; b=Y8yszdO151EB9wMNhi1HW4dOuxHTwQwVnVSjnyeZtClL7X3PTV8s0liC52tHM31+L7kulj wkJILZDISn2thUhTfZqAir7qfnv6V6TguCvdWfHjybHB1Ec1d3PeFbe5k/493IBlqiZ4xT nAq/CnXt9YNKgUe/B5c6avp4OXsRBlo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87y1hdluw4.fsf@breatheoutbreathe.in> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.221; envelope-from=joseph@breatheoutbreathe.in; helo=out-221.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 10 Sep 2023 15:00:08 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310444 Archived-At: Joseph Turner writes: > Joseph Turner writes: > >> Would you be open to adding an option to cl-defstruct that would alias >> the copier function to (lambda (obj) (copy-tree obj t)) instead of >> copy-sequence? >> >> If so, what kind of syntax would you want? Maybe something like >> >> (cl-defstruct (foo (:copier nil :recursive t)) a b c) > > Perhaps instead making copier always recursive, we could instead set the > copier to a separate function which optionally recurses: > > (cl-defun copy-foo (obj &key recursive) > "Copy OBJ with `copy-sequence'. If RECURSIVE, use `copy-tree'." > (if recursive > (copy-tree obj t) > (copy-sequence obj))) ... but this may be useless, since you can just use copy-tree.