From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Mon, 18 Sep 2023 09:25:48 +0200 Message-ID: <87ttrshrib.fsf@hyperspace> References: <87sfaz1men.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7710"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: philipk@posteo.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 18 12:19:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiBM9-0001fg-Hq for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Sep 2023 12:19:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiBKZ-0006TP-62; Mon, 18 Sep 2023 06:18:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qi8dp-0007tY-UZ for emacs-devel@gnu.org; Mon, 18 Sep 2023 03:25:57 -0400 Original-Received: from mout-p-202.mailbox.org ([80.241.56.172]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qi8dn-0001c3-Nq for emacs-devel@gnu.org; Mon, 18 Sep 2023 03:25:57 -0400 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4RpxCx3dFYz9sTM; Mon, 18 Sep 2023 09:25:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1695021949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=T3qeHD6k8Z5eDI4RVHqtHfyNU7S35rGNL2O59mS0Zgc=; b=REOdym5+9C0EvV7UBFo82/tIrfHhAj4/xP9KopHqG3BkHM3FGEeGh9eV2V3KT8/aFLXBkk 9rQECsBMUQsru4B/a9UdbnSp1fcs/NbQrkYndFivNF3sRDkHx6FiDeeW5pmg2V1aCNIfqM rrMwSTlO4T9MjSNWO7AXFA91ynMb53L23GKfxDSJpTbnQXupM8+pHwEJSmQ3i0kQ31o/oJ h/6p07GXGsROaqJt1IrpgNwYRHeIB7IpUisw3rihIFzvY8NNkmVhRDuUee+ilU5KkgyHOH 6+pnYEds++ZSv2t0/fQNWdBmi+8YLeYYLIusYqZC77WGFaHcsHY+fF2q477Oyg== In-Reply-To: <87sfaz1men.fsf@posteo.net> X-MBO-RS-META: bxaei3x8b1nzrmga5i4s9tffttt7cuiy X-MBO-RS-ID: 8b806cfa32a6910b68d Received-SPF: pass client-ip=80.241.56.172; envelope-from=tonyzorman@mailbox.org; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 18 Sep 2023 06:18:12 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310690 Archived-At: Hi, Philip Kaludercic writes: > But just like :make and :shell-command, or use-package support was not > intended in the beginning, I don't insist on anything as long as a > good compromise can be found. I just have my doubts, since supporting > this would probably run against a number of basic assumptions that > package-vc was written around. here's an idea: why not create e.g. a variable to decide when :shell-command is executed? Moving the execution to right after cloning the repository, instead of before building documentation, would enable one to easily emulate :files directives, as well as other keywords that need to be executed before things actually get built. Alternatively one could have a second :shell-command like keyword. Tony -- Tony Zorman | https://tony-zorman.com/