From: Philip Kaludercic <philipk@posteo.net>
To: Joost Kremers <joostkremers@fastmail.fm>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] csv-mode.el: Add function for reading a CSV line
Date: Sat, 25 May 2024 08:26:30 +0000 [thread overview]
Message-ID: <87ttimnvpl.fsf@posteo.net> (raw)
In-Reply-To: <86pltdizr4.fsf@fastmail.fm> (Joost Kremers's message of "Wed, 22 May 2024 18:21:19 +0200")
Joost Kremers <joostkremers@fastmail.fm> writes:
> On Wed, May 22 2024, Philip Kaludercic wrote:
> [patch]
>> Seems fine to me. I'd apply it if there are no objections. Until then,
>> you can prepare to modify your package to use this change.
>
> I was just about to suggest one more test. Specifically:
>
> ```
> (should (equal (let ((csv-field-quotes '("\"" "'")))
> (csv--unquote-value "'Hello, \"World\"'"))
> "Hello, \"World\""))
> ```
>
> It tests the case where the user defined more than one possible quote character,
> one being used to quote the field and the other being used inside the field.
>
> The attached patch adds this test but is otherwise identical to the previous
> one.
>
> Otherwise, thanks! :-)
Looks like nobody has any objections, so I pushed the changes to
elpa.git. Thanks.
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-05-25 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 22:55 [PATCH] csv-mode.el: Add function for reading a CSV line Joost Kremers
2024-05-22 6:17 ` Philip Kaludercic
2024-05-22 7:00 ` Joost Kremers
2024-05-22 16:14 ` Philip Kaludercic
2024-05-22 16:21 ` Joost Kremers
2024-05-25 8:26 ` Philip Kaludercic [this message]
2024-05-26 4:07 ` Stefan Monnier via Emacs development discussions.
2024-05-26 8:08 ` Joost Kremers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttimnvpl.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=joostkremers@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).