unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 1aa83da46d1 2/2: ; * etc/NEWS: Rename read-process-output-fast here also.
Date: Tue, 11 Jun 2024 10:32:53 +0200	[thread overview]
Message-ID: <87tthzg9qi.fsf@gmail.com> (raw)
In-Reply-To: <20240611064113.5E651C1FB57@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Tue, 11 Jun 2024 02:41:09 -0400 (EDT)")

>>>>> On Tue, 11 Jun 2024 02:41:09 -0400 (EDT), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

    Po Lu> branch: master
    Po Lu> commit 1aa83da46d1af60260b17522608eeca28efff151
    Po Lu> Author: Po Lu <luangruo@yahoo.com>
    Po Lu> Commit: Po Lu <luangruo@yahoo.com>

    Po Lu>     ; * etc/NEWS: Rename read-process-output-fast here also.
    Po Lu> ---
    Po Lu>  etc/NEWS | 2 +-
    Po Lu>  1 file changed, 1 insertion(+), 1 deletion(-)

    Po Lu> diff --git a/etc/NEWS b/etc/NEWS
    Po Lu> index 94557fdd255..a0223fb2dc6 100644
    Po Lu> --- a/etc/NEWS
    Po Lu> +++ b/etc/NEWS
    Po Lu> @@ -131,7 +131,7 @@ The round-trip through the Lisp function
    Po Lu>  'internal-default-process-filter' is skipped when the process filter is
    Po Lu>  the default one.  It's reimplemented in native code, reducing GC churn.
 
    Po Lu> -To undo the change, set 'read-process-output-fast' to nil.
    Po Lu> +To undo the change, set 'fast-read-process-output' to nil.
 
I realise weʼve renamed this one already, but would it not make more
sense for the variable to be called something starting with
'process-', such as 'process-fast-read-output'? Thatʼs in line with
other variables affecting the processes process data, such as
`process-adaptive-read-buffering'.

Robert
-- 



       reply	other threads:[~2024-06-11  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171808806905.4080.7963946550063771118@vcs2.savannah.gnu.org>
     [not found] ` <20240611064113.5E651C1FB57@vcs2.savannah.gnu.org>
2024-06-11  8:32   ` Robert Pluim [this message]
2024-06-11  8:35     ` master 1aa83da46d1 2/2: ; * etc/NEWS: Rename read-process-output-fast here also Po Lu
2024-06-11  8:36       ` Po Lu
2024-06-11 12:28     ` Dmitry Gutov
2024-06-11 12:35       ` Robert Pluim
2024-06-11 13:03         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tthzg9qi.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).