From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode' Date: Mon, 24 Jun 2024 15:01:24 +0000 Message-ID: <87tthi2xmj.fsf@posteo.net> References: <171921519771.16563.15139426619834982564@vcs2.savannah.gnu.org> <20240624074638.294E1C1FB6E@vcs2.savannah.gnu.org> <875xtybedy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11823"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 24 17:02:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLlCp-0002sG-GS for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jun 2024 17:02:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLlCG-0004Os-L2; Mon, 24 Jun 2024 11:01:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLlCF-0004Oe-Fk for emacs-devel@gnu.org; Mon, 24 Jun 2024 11:01:31 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLlCD-0003Ii-Ar for emacs-devel@gnu.org; Mon, 24 Jun 2024 11:01:31 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 64C17240029 for ; Mon, 24 Jun 2024 17:01:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719241286; bh=edhvQ4RWWBwClSmsXg19MEZVeU2bNoFjWaa0C1KHp44=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=DSz+G6XiggL66PBsk/gVevMtm6ud76mBjRmbCF1zTa6TWMPCXrWTIjT7gG0hRLy1f RNZoHiKiEqwDCccIkXXhNk3n5u3gV4KN0+iTfyC1XS6xbHqgTNCU8lyYocj7L7Y8Oi 69yo0jwT5RLfjeZTDfL2wM85AkDTgSNMS+MzaxJppYNCQkL8fyywgF0+TUSVILacoW 1cwJFb/FJgI4cvxpve0sHFKOz2ZE13rkVVWUaEG+g1/hshX9xVvPTf/sjy4lXoN92+ t4XLWoKEbrAyZfo+La8TBy6o3WCUG+1IX3TxOU9uNPijaHrXIRHyOpHwgGDIcis6Um tZYi14FRWaujw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W7B4P328Tz9rxB; Mon, 24 Jun 2024 17:01:25 +0200 (CEST) In-Reply-To: <875xtybedy.fsf@gmail.com> (Robert Pluim's message of "Mon, 24 Jun 2024 16:32:09 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320606 Archived-At: --=-=-= Content-Type: text/plain Robert Pluim writes: >>>>>> On Mon, 24 Jun 2024 03:46:37 -0400 (EDT), Philip Kaludercic > said: > > Philip> branch: emacs-30 > Philip> commit 768e92b9c0214a2aa1be2afbee48c455583d3110 > Philip> Author: Philip Kaludercic > Philip> Commit: Philip Kaludercic > > Philip> Update options that depend on 'which-key-dont-use-unicode' > > Philip> * lisp/which-key.el (which-key-dont-use-unicode): Add a custom setter > Philip> that re-evaluates a manual list of options use > Philip> 'which-key-dont-use-unicode' to determine their default value. > > Philip> https://lists.gnu.org/archive/html/help-gnu-emacs/2024-06/msg00130.html > > This commit causes `which-key-separator' and `which-key-ellipsis' to > be nil for me (after `which-key-mode'). Reverting this commit fixes it. Eh, that might be because `which-key-dont-use-unicode' is being evaluated before the other two options, but the :set function is giving them initial values (nil), even though we haven't determined their default value yet. Does --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/which-key.el b/lisp/which-key.el index 91007ce4ada..8b78bfb2576 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -133,6 +133,7 @@ which-key-dont-use-unicode (mapc #'custom-reevaluate-setting '(which-key-separator which-key-ellipsis))) + :initialize #'custom-initialize-changed :type 'boolean :package-version "1.0" :version "30.1") --=-=-= Content-Type: text/plain make sense? I am always uncertain which :initialize value to use. > Robert -- Philip Kaludercic on peregrine --=-=-=--