Re: emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode'

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Mon, 24 Jun 2024 03:46:37 -0400 (EDT), Philip Kaludercic
> <philipk@posteo.net> said:
>
>     Philip> branch: emacs-30
>     Philip> commit 768e92b9c0214a2aa1be2afbee48c455583d3110
>     Philip> Author: Philip Kaludercic <philipk@posteo.net>
>     Philip> Commit: Philip Kaludercic <philipk@posteo.net>
>
>     Philip>     Update options that depend on 'which-key-dont-use-unicode'
>     
>     Philip>     * lisp/which-key.el (which-key-dont-use-unicode): Add a custom setter
>     Philip>     that re-evaluates a manual list of options use
>     Philip>     'which-key-dont-use-unicode' to determine their default value.
>     
>     Philip>     https://lists.gnu.org/archive/html/help-gnu-emacs/2024-06/msg00130.html
>
> This commit causes `which-key-separator' and `which-key-ellipsis' to
> be nil for me (after `which-key-mode'). Reverting this commit fixes it.

Eh, that might be because `which-key-dont-use-unicode' is being
evaluated before the other two options, but the :set function is giving
them initial values (nil), even though we haven't determined their
default value yet.

Does


[-- Attachment #2: Type: text/plain, Size: 412 bytes --]

diff --git a/lisp/which-key.el b/lisp/which-key.el
index 91007ce4ada..8b78bfb2576 100644
--- a/lisp/which-key.el
+++ b/lisp/which-key.el
@@ -133,6 +133,7 @@ which-key-dont-use-unicode
          (mapc #'custom-reevaluate-setting
                '(which-key-separator
                  which-key-ellipsis)))
+  :initialize #'custom-initialize-changed
   :type 'boolean
   :package-version "1.0" :version "30.1")
 

[-- Attachment #3: Type: text/plain, Size: 115 bytes --]


make sense?  I am always uncertain which :initialize value to use.

> Robert

-- 
	Philip Kaludercic on peregrine