Re: : master 7f97cf31dc3: Create blessmail at build time instead of install time

[Pip Cet <pipcet@protonmail.com>]

"Robert Pluim" <rpluim@gmail.com> writes:

>>>>>> On Fri, 23 Aug 2024 12:17:26 +0000, Pip Cet <pipcet@protonmail.com> said:
>
>     Pip> "Robert Pluim" <rpluim@gmail.com> writes:
>     >> branch: master
>     >> commit 7f97cf31dc3eb483f84598f61e9f45805f901067
>     >> Author: Robert Pluim <rpluim@gmail.com>
>     >> Commit: Robert Pluim <rpluim@gmail.com>
>     >>
>     >> Create blessmail at build time instead of install time
>     >>
>     >> blessmail is built via the install target, which means it ends up owned
>     >> by the user doing the install.  It's not installed, so build it at build
>     >> time instead.
>     >>
>     >> Reported by Michael Heerdegen <michael_heerdegen@web.de> in
>     >> <https://lists.gnu.org/archive/html/help-gnu-emacs/2024-08/msg00270.html>
>     >>
>     >> * Makefile.in (install): Move blessmail target from install to actual-all.
>
>     Pip> All the patch appears to do is to remove blessmail from 'install', so
>     Pip> it's no longer run at all.  Maybe there's a second part to it that
>     Pip> wasn't committed?  Or am I missing something?
>
> Oops. I just pushed the 2nd half of the patch.

I still don't understand this change, I'm afraid.  IIUC, the idea is
that this message is printed at install time, not at build time:

Assuming /usr/spool/mail is really the mail spool directory, you should
run  lib-src/blessmail /usr/local/libexec/emacs/31.0.50/x86_64-pc-linux-gnu/movemail
as root, to give  movemail  appropriate permissions.
Do that after running  make install.


It's not clear to me that building lib-src/blessmail at build time is
always safe: the user building Emacs might well be in a chroot jail or
restricted so they're unable to access 'rmail-spool-directory'.

As this is really a post-install dependency, I think we need to find a
better way of dealing with it.  Maybe we can do without "blessmail"
entirely, and have "blessmail.el" print the full instructions when run,
rather than putting them into "blessmail"?

Pip