From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 14:05:30 +0200 Message-ID: <87tte6y3qt.fsf@gnu.org> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> <87zfo22jy4.fsf@ice9.digital> <86bk0h5sx9.fsf@gnu.org> <87ldzlgxvh.fsf@ice9.digital> <87msk0oqoq.fsf@gnu.org> <87plovmmox.fsf@ice9.digital> <8734lqzx64.fsf@gnu.org> <864j66h9ey.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.6; emacs 31.0.50 Cc: morgan@ice9.digital, emacs-devel@gnu.org, visuweshm@gmail.com, Manuel Giraud To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 14:06:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sshpj-0000Sa-BZ for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 14:06:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sshow-0004zZ-9D; Mon, 23 Sep 2024 08:05:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshou-0004z8-8Z for emacs-devel@gnu.org; Mon, 23 Sep 2024 08:05:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshot-0001UX-7V; Mon, 23 Sep 2024 08:05:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=J/IHXksEJt1/asfECfXJbrNCon9MjQJCy+XzLufNZS8=; b=fx+E0fPijVEFeejMGkbH Y/9hSTLzKdCa0f8OH4ibUy4pZ5A1SBtc0QlqvWM0N3H0zb6ZNzjDagkpHFfPkhMKwFP8UkzYuGRLD yEREI/IsK/c6pql+R4a6VVLgFREJmYxZeZ32MJGujceiX8fT1li9W0KasPiGPSISeAwZlckRjOg2T P7oqJSHk4Xy+2oVck2G+Ggfo63zqj3LvhfaHlVZRvZxGkBBiuYeC8apymhPVyIssYqhD2FLbmv3It 84JiqsisAWBiE2mPkd2OfpQ+RhiY5jmQwVfzVGKn9iK3fOil6t6pZHDKT/58M2G+0nzhEqythPD+D HadrI7e142baJQ==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelledghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgesthdtredttdertden ucfhrhhomhepvfgrshhsihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenuc ggtffrrghtthgvrhhnpeeluddvgeefuddvjeekfeetleegtefgveehhfeuffeuffeghefg ueefgfdvffegtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieej feekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilh drfhhmpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthho pehmrghnuhgvlheslhgvughuqdhgihhrrghuugdrfhhrpdhrtghpthhtohepvhhishhufi gvshhhmhesghhmrghilhdrtghomhdprhgtphhtthhopegvmhgrtghsqdguvghvvghlsehg nhhurdhorhhgpdhrtg X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <864j66h9ey.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Sep 2024 14:55:01 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323958 Archived-At: Eli Zaretskii writes: >> Eli, what do you think? > > Sorry, I don't understand what you are asking me about. Please > elaborate > > It sounds like PDF documents with colors have inherent problems with > doc-view-mupdf-use-svg and/or themes, so maybe we should warn about > this in NEWS and in the doc string, and suggest that people either > customize the doc-view-svg-face, or disable doc-view-mupdf-use-svg. Yes, exactly. There can be foreground-similar-to-background color issues when mupdf + doc-view-mupdf-use-svg is used for certain, not uncommon documents. We can either document that issue in NEWS and docstrings, or we can simply set "black on white" as default value of doc-view-svg-face which would eliminate those problems (and match what we had in emacs 29 before the face was introduced by Manuel Giraud) but would stop trying to apply our emacs theme to the document, too. I'd rather be conservative, use "black on white" as doc-view-svg-face default value and document in NEWS and doc-view-svg-face's docstring that one can style documents according to the emacs theme by inheriting from the default face and not explicitly setting foreground and background colors. Bye, Tassilo