unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Replacement for C-x 8 based on input methods
Date: 15 May 2002 00:38:27 +0900	[thread overview]
Message-ID: <87sn4urb7w.fsf@tc-1-100.kawasaki.gol.ne.jp> (raw)
In-Reply-To: <vaf4rha7o8d.fsf@INBOX.auto.emacs.devel.tok.lucy.cs.uni-dortmund.de>

A few comments:

. I don't like the prompt -- I like the way the old C-x 8 code doesn't
  show anything in the input area [until the normal time-delayed
  key-echo display shows something -- note that this still happens if
  you use `read-char' without a prompt]

. It's not necessary to say

      (if old-method
	  (activate-input-method old-method)
	(inactivate-input-method)))))

  because `activate-input-method' will do the Right Thing if
  old-method is nil.

. You don't have to convert the character list to a string and then
  insert it -- you can just apply #'insert to the list, because insert
  also works with multiple character arguments...

(sorry if these seem like nit-picking!)

-Miles
-- 
I'm beginning to think that life is just one long Yoko Ono album; no rhyme
or reason, just a lot of incoherent shrieks and then it's over.  --Ian Wolff

  reply	other threads:[~2002-05-14 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-14 15:17 Replacement for C-x 8 based on input methods Kai Großjohann
2002-05-14 15:38 ` Miles Bader [this message]
2002-05-14 16:11   ` Kai Großjohann
2002-05-14 23:31     ` Miles Bader
2002-05-15  1:21     ` Miles Bader
2002-05-16  7:21     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sn4urb7w.fsf@tc-1-100.kawasaki.gol.ne.jp \
    --to=miles@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).